"FlaggablePageTest::testPageDataFromTitle" erroring on patches in it and its many dependent repos
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdforrester-WMF
	Jan 15 2021, 5:47 PM

Description

PHPUnit failure:

09:38:54 1) FlaggablePageTest::testPageDataFromTitle
09:38:54 MWException: Title 'somePage' cannot exist as a page
09:38:54 
09:38:54 /workspace/src/includes/page/WikiPage.php:146
09:38:54 /workspace/src/extensions/FlaggedRevs/tests/phpunit/FlaggablePageTest.php:23
09:38:54 /workspace/src/maintenance/doMaintenance.php:106

Selenium failure (when trying to view Special:UserLogin):
https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-selenium-docker/25393/artifact/log/Page-should-be-deletable.png

Details

Subject	Repo	Branch	Lines +/-
Use FlaggableWikiPage only for real pages	mediawiki/extensions/FlaggedRevs	master	+6 -5
Revert "Make WikiPage a ProperPageIdentity"	mediawiki/core	master	+29 -140
Revert "Define equality for PageIdentity and Link_target"	mediawiki/core	master	+27 -464
FlaggablePageTest::testPageDataFromTitle: Use an initial capital so MW doesn't throw	mediawiki/extensions/FlaggedRevs	master	+1 -1

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open	BUG REPORT	None	T12863 Links on commons upload summaries do not link to commons
Open		None	T5498 Image history is confusing
Stalled		None	T96384 Integrate file revisions with description page history
Open		None	T115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
Open		None	T115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
Duplicate		None	T115864 Figure out if the description of the image can be used as the caption on-wiki
Open	Feature	None	T53032 When inserting an image, set its caption by default to be the Commons image description
Open	Feature	None	T39534 Wikimedia Commons should support searching by color
Duplicate		None	T39535 Wikimedia Commons should support filtering by color
Resolved		None	T19503 Provide metadata support on Wikimedia Commons
Open		None	T122038 Moving/Deleting a video file does not move/delete subtitles files, nor does it inform the file mover of their existence
Open		None	T135221 Make TimedText content an integral part of the File page
Open	Feature	None	T2167 Use a dedicated interface for adding meta-data like interwiki links, rather than wikitext
Open		None	T132072 Integrate page meta-data as a new content model revision slot for consistency and atomicity
Resolved		None	T51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
Resolved		None	T68108 [Epic] Store media information for files on Wikimedia Commons as structured data
Open	Feature	None	T14963 allow per-page exceptions to spam blacklist
Open		None	T203157 Make the spam whitelist its own slot
Open	Feature	None	T56140 Move TemplateData to its own JSON-content namespace and associate with Template-namespace, or to its own TemplateData content model and revision slot
Stalled		None	T174043 Deploy Multi-Content Revisions
Open		None	T174022 Implement multi-content revisions
Open		daniel	T196087 Refactored implementation of MCR page update interface
Open		pmiazga	T302623 FY2022-2023: Improve Backend Pageview Timing
Resolved		None	T206498 MediaWiki needlessly queries page data twice on page views
Invalid		None	T273514 MW expedition work [high effort]
Open		None	T273542 Migrate ZObjectStore from WikiPage to PageStore now it exists
Resolved		None	T195069 Factor PageStore and PageRecord out of WikiPage
Resolved		daniel	T272421 Make WikiPage a PageRecord
Resolved		daniel	T272424 Make WikiPage a ProperPageIdentity
Resolved		daniel	T272518 Watch for extensions broken by WikiPage now deprecating construction on bad titles
Resolved		Jdforrester-WMF	T272170 "FlaggablePageTest::testPageDataFromTitle" erroring on patches in it and its many dependent repos

Event Timeline

Jdforrester-WMF triaged this task as Unbreak Now! priority.Jan 15 2021, 5:47 PM

Jdforrester-WMF created this task.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 15 2021, 5:47 PM

Could be https://gerrit.wikimedia.org/r/c/mediawiki/core/+/630182 ?

In T272170#6751963, @Esanders wrote:

Could be https://gerrit.wikimedia.org/r/c/mediawiki/core/+/630182 ?

Possibly; FR is not in the gate for core.

Looks like this error is new in rMW8f46ef5ff4cf: Make WikiPage a ProperPageIdentity.

Change 656461 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/FlaggedRevs@master] FlaggablePageTest::testPageDataFromTitle: Use an initial capital so MW doesn't throw

https://gerrit.wikimedia.org/r/656461

gerritbot added a project: Patch-For-Review.Jan 15 2021, 5:57 PM

Jdforrester-WMF renamed this task from "FlaggablePageTest::testPageDataFromTitle" erroring on all MediaWiki patches to "FlaggablePageTest::testPageDataFromTitle" erroring on patches in it and its many dependent repos.Jan 15 2021, 6:04 PM

RhinosF1 subscribed.Jan 15 2021, 6:55 PM

matmarex subscribed.Jan 15 2021, 8:10 PM

Change 656468 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Revert "Make WikiPage a ProperPageIdentity"

https://gerrit.wikimedia.org/r/656468

Change 656507 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Revert "Define equality for PageIdentity and Link_target"

https://gerrit.wikimedia.org/r/656507

matmarex mentioned this in T208776: RFC: Introduce PageIdentity to be used instead of WikiPage.Jan 15 2021, 8:43 PM

Change 656461 abandoned by Jforrester:
[mediawiki/extensions/FlaggedRevs@master] FlaggablePageTest::testPageDataFromTitle: Use an initial capital so MW doesn't throw

Reason:

https://gerrit.wikimedia.org/r/656461

matmarex updated the task description. (Show Details)Jan 15 2021, 8:47 PM

Jdforrester-WMF claimed this task.Jan 15 2021, 8:47 PM

Change 656507 merged by jenkins-bot:
[mediawiki/core@master] Revert "Define equality for PageIdentity and Link_target"

https://gerrit.wikimedia.org/r/656507

Change 656468 merged by jenkins-bot:
[mediawiki/core@master] Revert "Make WikiPage a ProperPageIdentity"

https://gerrit.wikimedia.org/r/656468

OK, things look fixed.

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.27; 2021-01-19).Jan 15 2021, 10:00 PM

Can we add flagged revs to MW gate? This is maybe the 5th time over a year I remember FlaggedRevs being broken by core changes, so it seems like a good addition to MW gate

In T272170#6753458, @Pchelolo wrote:

Can we add flagged revs to MW gate? This is maybe the 5th time over a year I remember FlaggedRevs being broken by core changes, so it seems like a good addition to MW gate

Yes, probably (overall tracked at T249674: Have all Wikimedia production extensions and skins in the CI gate), but I vaguely remember there being issues about how FR interferes with other extensions' tests.

Change 656944 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/extensions/FlaggedRevs@master] Use FlaggableWikiPage only for real pages

https://gerrit.wikimedia.org/r/656944

Change 656906 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Re-apply "Make WikiPage a ProperPageIdentity"

https://gerrit.wikimedia.org/r/656906

Change 656948 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Re-apply "Define equality for PageIdentity and Link_target"

https://gerrit.wikimedia.org/r/656948

Change 656944 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Use FlaggableWikiPage only for real pages

https://gerrit.wikimedia.org/r/656944

Jdforrester-WMF added a parent task: T272518: Watch for extensions broken by WikiPage now deprecating construction on bad titles.Jan 20 2021, 5:57 PM

"FlaggablePageTest::testPageDataFromTitle" erroring on patches in it and its many dependent reposClosed, ResolvedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

"FlaggablePageTest::testPageDataFromTitle" erroring on patches in it and its many dependent repos
Closed, ResolvedPublic
Actions

Related Objects
Search...