Page MenuHomePhabricator
Create Task
Maniphest T275602

Avoid using User ::isIP, ::getOptions
Closed, ResolvedPublic
Actions

Assigned To
Vlad.shapik
Authored By
Vlad.shapik
Feb 24 2021, 10:43 AM
Tags
Referenced Files
None
Subscribers
Aklapper
HMonroy
Masumrezarock100
• Pchelolo
Peter.ovchyn
Samwilson
Vlad.shapik

Description

User::isIP, User::getOptions were soft deprecated and now need to be hard deprecated. So we need to remove using from the extensions and skins:

  • GrowthExperiments(Ext)
  • Echo(Ext)
  • LdapAuthentication(Ext)
  • VisualEditor(Ext)
  • Wikibase(Ext)
  • WikimediaIncubator(Ext)
  • MinervaNeue(Skin)
  • Nostalgia(Skin)
  • GlobalPreferences(Ext)
  • RegexBlock(Ext)
  • BlueSpiceEchoConnector(Ext)
  • BreadCrumbs(Ext)
  • MediaWikiAuth(Ext)
  • LDAPUserInfo(Ext)
  • LookupUser(Ext)
  • BlueSpiceAuthors(Ext)
  • BlueSpiceReaders(Ext)
  • BlueSpiceExtendedSearch(Ext)
  • ChangeAuthor(Ext)
  • CreatedPagesList(Ext)
  • SocialProfile(Ext)
  • Sudo(Ext)
  • StaffPowers(Ext)
  • NoBogusUserpages(Ext)
  • OnlineStatusBar(Ext)
  • BlueSpiceSmartLis(Ext)

Details

SubjectRepoBranchLines +/-
Avoid using User::isIPmediawiki/extensions/OnlineStatusBarmaster+27 -7
Avoid using User::isIPmediawiki/extensions/ChangeAuthormaster+15 -3
Avoid using User::isIPmediawiki/extensions/NoBogusUserpagesmaster+4 -1
Remove usages of deprecated methods in CreatedPagesListRecalculateTestmediawiki/extensions/CreatedPagesListmaster+34 -20
Avoid using User::getOptionsmediawiki/extensions/BreadCrumbsmaster+3 -2
Hard deprecate User ::isIP, ::getOptionsmediawiki/coremaster+207 -68
Avoid using User ::getOptions, ::GETOPTIONS_EXCLUDE_DEFAULTSmediawiki/extensions/LDAPUserInfomaster+5 -3
Avoid using User ::getOptions, ::GETOPTIONS_EXCLUDE_DEFAULTSmediawiki/extensions/LDAPUserInfoREL1_35+5 -3
Avoid using User::isIPmediawiki/extensions/BlueSpiceSmartListmaster+4 -3
Avoid using User::isIPmediawiki/extensions/StaffPowersmaster+5 -2
Avoid using User::isIPmediawiki/extensions/ChangeAuthormaster+11 -1
Avoid using User::isIPmediawiki/extensions/Sudomaster+12 -1
Avoid using User::isIPmediawiki/extensions/SocialProfilemaster+6 -3
Avoid using User::isIPmediawiki/extensions/BlueSpiceReadersmaster+8 -8
Avoid using User::isIPmediawiki/extensions/BlueSpiceAuthorsmaster+4 -2
Avoid using User ::getOptions, ::isIPmediawiki/extensions/LookupUsermaster+22 -2
Avoid using User::getOptionsmediawiki/extensions/BlueSpiceExtendedSearchmaster+5 -2
Avoid using User ::getOptions, ::getOptionKinds, ::setOptionmediawiki/extensions/GlobalPreferencesmaster+129 -46
Remove using User ::addGroup, ::getOptions, ::setOptionmediawiki/extensions/MediaWikiAuthmaster+30 -7
Avoid using User::isIPmediawiki/extensions/RegexBlockmaster+4 -2
Avoid using User::getOptionsmediawiki/extensions/BlueSpiceEchoConnectormaster+3 -1
Avoid using User::getOptionsmediawiki/extensions/GrowthExperimentsmaster+17 -10
Avoid using User::isIPmediawiki/extensions/WikimediaIncubatormaster+15 -4
Avoid using User::isIPmediawiki/extensions/Wikibasemaster+25 -7
Avoid using User::isIPmediawiki/skins/MinervaNeuemaster+22 -12
Avoid using User::isIPmediawiki/skins/Nostalgiamaster+2 -1
Avoid using User::IsIPmediawiki/extensions/VisualEditormaster+16 -4
Avoid using User::IsIPmediawiki/extensions/Echomaster+4 -2
Avoid using User::IsIPmediawiki/extensions/LdapAuthenticationmaster+2 -1
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
gerritbot added a comment.Feb 24 2021, 9:13 PM

Change 666654 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Avoid using User::IsIP

https://gerrit.wikimedia.org/r/666654

gerritbot added a comment.Feb 25 2021, 7:07 PM

Change 666976 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/Wikibase@master] Avoid using User::IsIP

https://gerrit.wikimedia.org/r/666976

gerritbot added a comment.Feb 25 2021, 7:24 PM

Change 666977 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/WikimediaIncubator@master] Avoid using User::IsIP

https://gerrit.wikimedia.org/r/666977

gerritbot added a comment.Feb 26 2021, 10:45 AM

Change 667137 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/skins/MinervaNeue@master] Avoid using User::IsIP

https://gerrit.wikimedia.org/r/667137

gerritbot added a comment.Feb 26 2021, 1:52 PM

Change 667164 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/skins/Nostalgia@master] Avoid using User::IsIP

https://gerrit.wikimedia.org/r/667164

gerritbot added a comment.Feb 26 2021, 5:41 PM

Change 667215 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/GlobalPreferences@master] Avoid using User::getOptions

https://gerrit.wikimedia.org/r/667215

gerritbot added a comment.Mar 1 2021, 8:16 PM

Change 667164 merged by jenkins-bot:
[mediawiki/skins/Nostalgia@master] Avoid using User::isIP

https://gerrit.wikimedia.org/r/667164

CCicalese_WMF moved this task from UserStore pile to Waiting for Review on the Platform Team Workboards (MW Expedition) board.Mar 2 2021, 6:41 PM
gerritbot added a comment.Mar 2 2021, 7:43 PM

Change 667137 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Avoid using User::isIP

https://gerrit.wikimedia.org/r/667137

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.34; 2021-03-09); removed MW-1.36-notes (1.36.0-wmf.33; 2021-03-02).Mar 2 2021, 8:00 PM
gerritbot added a comment.Mar 3 2021, 11:35 AM

Change 666976 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Avoid using User::isIP

https://gerrit.wikimedia.org/r/666976

gerritbot added a comment.Mar 3 2021, 7:43 PM

Change 666977 merged by Ebe123:
[mediawiki/extensions/WikimediaIncubator@master] Avoid using User::isIP

https://gerrit.wikimedia.org/r/666977

ArTrix updated the task description. (Show Details)Mar 9 2021, 9:41 PM
ppelberg moved this task from To Triage to Triaged on the VisualEditor board.Mar 18 2021, 3:37 PM
ppelberg added a project: Editing-team (Tracking).
ppelberg moved this task from Backlog to External on the Editing-team (Tracking) board.
gerritbot added a comment.Mar 18 2021, 6:43 PM

Change 666605 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Avoid using User::getOptions

https://gerrit.wikimedia.org/r/666605

Vlad.shapik updated the task description. (Show Details)Mar 18 2021, 6:44 PM
ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.36; 2021-03-23); removed MW-1.36-notes (1.36.0-wmf.34; 2021-03-09).Mar 18 2021, 7:00 PM
Vlad.shapik added subscribers: Samwilson, Legoktm.Mar 26 2021, 12:47 PM

Hi @Legoktm, @Samwilson.
Since you are the maintainers of the GlobalPreferences extension, could you review the patch, please?
It also will help to move the patch for the core forward.

Legoktm added a comment.Mar 26 2021, 5:06 PM
In T275602#6948699, @Vlad.shapik wrote:

Hi @Legoktm, @Samwilson.
Since you are the maintainers of the GlobalPreferences extension, could you review the patch, please?

I'm one of the original authors, but no longer a maintainer (see https://www.mediawiki.org/wiki/Developers/Maintainers)

Vlad.shapik added a comment.Mar 29 2021, 8:15 AM
In T275602#6949402, @Legoktm wrote:
In T275602#6948699, @Vlad.shapik wrote:

Hi @Legoktm, @Samwilson.
Since you are the maintainers of the GlobalPreferences extension, could you review the patch, please?

I'm one of the original authors, but no longer a maintainer (see https://www.mediawiki.org/wiki/Developers/Maintainers)

Ok, thanks!

Vlad.shapik added subscribers: HMonroy, MusikAnimal.Mar 29 2021, 9:03 AM

I found out that the GlobalPreferences extension doesn't have any maintainers. But this code base has the code steward - Community Tech.
Could @MusikAnimal, @Samwilson, @HMonroy help with mergeing the patch(Avoid using User ::getOptions, ::getOptionKinds, ::setOption, ::saveSettings) of the GlobalPreferences extension?
This patch blocks the deprecation patch for the core and the patch which will remove the compatibility code from the constructor of the DefaultPreferencesFactory class.

gerritbot added a comment.Mar 29 2021, 11:15 AM

Change 675494 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):
[mediawiki/extensions/RegexBlock@master] Avoid using User::isIP

https://gerrit.wikimedia.org/r/675494

gerritbot added a comment.Mar 29 2021, 11:50 AM

Change 675497 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):
[mediawiki/extensions/BlueSpiceEchoConnector@master] Avoid using User::getOptions

https://gerrit.wikimedia.org/r/675497

Vlad.shapik updated the task description. (Show Details)Mar 29 2021, 1:19 PM
Vlad.shapik updated the task description. (Show Details)Mar 29 2021, 1:45 PM
Vlad.shapik added a comment.EditedMar 29 2021, 1:55 PM

FYI
I added the undeployed extensions through the CodeSearch to the checklist in the two last updates of the task description .

Vlad.shapik added projects: RegexBlock, BlueSpice, MediaWiki-extensions-BreadCrumbs, MediaWiki-extensions-MediaWikiAuth, MediaWiki-extensions-LDAPUserInfo, LookupUser, MediaWiki-extensions-Other, SocialProfile, MediaWiki-extensions-Sudo, MediaWiki-extensions-OnlineStatusBar.Mar 29 2021, 2:04 PM
gerritbot added a comment.Mar 29 2021, 2:31 PM

Change 675522 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):
[mediawiki/extensions/BreadCrumbs@master] Avoid using User::getOptions

https://gerrit.wikimedia.org/r/675522

Maintenance_bot added a project: Social-Tools.Mar 29 2021, 2:45 PM
gerritbot added a comment.Mar 29 2021, 5:52 PM

Change 675570 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):
[mediawiki/extensions/MediaWikiAuth@master] Prevent using User ::addGroup, ::getOptions, ::setOption

https://gerrit.wikimedia.org/r/675570

Legoktm unsubscribed.Mar 29 2021, 7:22 PM
gerritbot added a comment.Mar 30 2021, 7:36 AM

Change 675497 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceEchoConnector@master] Avoid using User::getOptions

https://gerrit.wikimedia.org/r/675497

Vlad.shapik mentioned this in rEBTY44efd0e176f4: Avoid using User::getOptions.Mar 30 2021, 7:39 AM
gerritbot added a comment.Mar 30 2021, 3:11 PM

Change 675494 merged by Jack Phoenix:
[mediawiki/extensions/RegexBlock@master] Avoid using User::isIP

https://gerrit.wikimedia.org/r/675494

Vlad.shapik mentioned this in rERXB271f3c092a69: Avoid using User::isIP.Mar 30 2021, 3:44 PM
gerritbot added a comment.Mar 31 2021, 4:13 PM

Change 675570 merged by jenkins-bot:

[mediawiki/extensions/MediaWikiAuth@master] Remove using User ::addGroup, ::getOptions, ::setOption

https://gerrit.wikimedia.org/r/675570

Vlad.shapik mentioned this in rEMWAeed72801a552: Remove using User ::addGroup, ::getOptions, ::setOption.Mar 31 2021, 4:19 PM
gerritbot added a comment.Apr 2 2021, 2:08 PM

Change 676583 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/LDAPUserInfo@master] Avoid using User ::getOptions, ::GETOPTIONS_EXCLUDE_DEFAULTS

https://gerrit.wikimedia.org/r/676583

gerritbot added a comment.Apr 2 2021, 3:17 PM

Change 676597 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/LookupUser@master] Avoid using User ::getOptions, ::isIP

https://gerrit.wikimedia.org/r/676597

gerritbot added a comment.Apr 2 2021, 4:14 PM

Change 676610 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/BlueSpiceAuthors@master] Avoid using User::isIP

https://gerrit.wikimedia.org/r/676610

gerritbot added a comment.Apr 2 2021, 4:22 PM

Change 676611 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/BlueSpiceReaders@master] Avoid using User::isIP

https://gerrit.wikimedia.org/r/676611

gerritbot added a comment.Apr 2 2021, 4:34 PM

Change 676612 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/BlueSpiceExtendedSearch@master] Avoid using User::getOptions

https://gerrit.wikimedia.org/r/676612

gerritbot added a comment.Apr 2 2021, 5:35 PM

Change 676630 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/ChangeAuthor@master] Avoid using User::isIP

https://gerrit.wikimedia.org/r/676630

Vlad.shapik updated the task description. (Show Details)Apr 2 2021, 5:53 PM
Vlad.shapik updated the task description. (Show Details)Apr 2 2021, 6:41 PM
gerritbot added a comment.Apr 2 2021, 7:00 PM

Change 667215 merged by jenkins-bot:

[mediawiki/extensions/GlobalPreferences@master] Avoid using User ::getOptions, ::getOptionKinds, ::setOption

https://gerrit.wikimedia.org/r/667215

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.38; 2021-04-06); removed MW-1.36-notes (1.36.0-wmf.36; 2021-03-23).Apr 2 2021, 8:00 PM
gerritbot added a comment.Apr 2 2021, 8:34 PM

Change 676612 merged by jenkins-bot:

[mediawiki/extensions/BlueSpiceExtendedSearch@master] Avoid using User::getOptions

https://gerrit.wikimedia.org/r/676612

Vlad.shapik mentioned this in rEBSESc8f0bd25d0f9: Avoid using User::getOptions.Apr 2 2021, 8:40 PM
gerritbot added a comment.Apr 3 2021, 8:41 AM

Change 676597 merged by jenkins-bot:

[mediawiki/extensions/LookupUser@master] Avoid using User ::getOptions, ::isIP

https://gerrit.wikimedia.org/r/676597

Vlad.shapik mentioned this in rELOU155d94451a1f: Avoid using User ::getOptions, ::isIP.Apr 3 2021, 9:27 AM
gerritbot added a comment.Apr 3 2021, 11:28 AM

Change 676720 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/CreatedPagesList@master] Remove usage of deprecated methods in CreatedPagesListRecalculateTest

https://gerrit.wikimedia.org/r/676720

Vlad.shapik updated the task description. (Show Details)Apr 3 2021, 11:36 AM
gerritbot added a comment.Apr 4 2021, 7:28 AM

Change 676610 merged by jenkins-bot:

[mediawiki/extensions/BlueSpiceAuthors@master] Avoid using User::isIP

https://gerrit.wikimedia.org/r/676610

Vlad.shapik mentioned this in rEBSD7918d7c50424: Avoid using User::isIP.Apr 4 2021, 7:30 AM
gerritbot added a comment.Apr 4 2021, 7:31 AM

Change 676611 merged by jenkins-bot:

[mediawiki/extensions/BlueSpiceReaders@master] Avoid using User::isIP

https://gerrit.wikimedia.org/r/676611

Vlad.shapik mentioned this in rEBSW4dabeb0750fd: Avoid using User::isIP.Apr 4 2021, 7:34 AM
gerritbot added a comment.Apr 4 2021, 4:50 PM

Change 676810 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/SocialProfile@master] Avoid using User::isIP

https://gerrit.wikimedia.org/r/676810

gerritbot added a comment.Apr 4 2021, 5:07 PM

Change 676812 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/Sudo@master] Avoid using User::isIP

https://gerrit.wikimedia.org/r/676812

gerritbot added a comment.Apr 4 2021, 5:41 PM

Change 676816 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/StaffPowers@master] Avoid using User::isIP

https://gerrit.wikimedia.org/r/676816

gerritbot added a comment.Apr 4 2021, 6:35 PM

Change 676810 merged by jenkins-bot:

[mediawiki/extensions/SocialProfile@master] Avoid using User::isIP

https://gerrit.wikimedia.org/r/676810

gerritbot added a comment.Apr 4 2021, 6:35 PM

Change 676812 merged by jenkins-bot:

[mediawiki/extensions/Sudo@master] Avoid using User::isIP

https://gerrit.wikimedia.org/r/676812

gerritbot added a comment.Apr 4 2021, 6:46 PM

Change 676831 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/NoBogusUserpages@master] Avoid using User::isIP

https://gerrit.wikimedia.org/r/676831

Vlad.shapik updated the task description. (Show Details)Apr 4 2021, 7:02 PM
Vlad.shapik mentioned this in rESPR42c0593e81ac: Avoid using User::isIP.Apr 4 2021, 7:40 PM
Vlad.shapik moved this task from Waiting for Review to Doing on the Platform Team Workboards (MW Expedition) board.Apr 5 2021, 10:13 AM
gerritbot added a comment.Apr 5 2021, 2:38 PM

Change 676630 abandoned by Vlad.shapik:

[mediawiki/extensions/ChangeAuthor@master] Avoid using User::isIP

Reason:

Wrong patch

https://gerrit.wikimedia.org/r/676630

gerritbot added a comment.Apr 5 2021, 2:41 PM

Change 676939 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/ChangeAuthor@master] Avoid using User::isIP

https://gerrit.wikimedia.org/r/676939

gerritbot added a comment.Apr 5 2021, 3:41 PM

Change 676943 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/OnlineStatusBar@master] Avoid using User::isIP

https://gerrit.wikimedia.org/r/676943

Vlad.shapik updated the task description. (Show Details)Apr 5 2021, 3:45 PM
MusikAnimal unsubscribed.Apr 5 2021, 11:57 PM
gerritbot added a comment.Apr 6 2021, 2:27 PM

Change 677275 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/BlueSpiceSmartList@master] Avoid using User::isIP

https://gerrit.wikimedia.org/r/677275

Vlad.shapik updated the task description. (Show Details)Apr 6 2021, 2:47 PM
• Pchelolo added a comment.Apr 6 2021, 5:37 PM

If all deployed extesions were updated then it's ready for a patch to hard deprecate the methods.

Vlad.shapik added a comment.Apr 6 2021, 5:39 PM

I am working on a patch for the core.

gerritbot added a comment.Apr 6 2021, 10:28 PM

Change 676816 merged by jenkins-bot:

[mediawiki/extensions/StaffPowers@master] Avoid using User::isIP

https://gerrit.wikimedia.org/r/676816

gerritbot added a comment.Apr 12 2021, 11:26 AM

Change 677275 merged by jenkins-bot:

[mediawiki/extensions/BlueSpiceSmartList@master] Avoid using User::isIP

https://gerrit.wikimedia.org/r/677275

Vlad.shapik mentioned this in rEBTXf00698691ef6: Avoid using User::isIP.Apr 12 2021, 11:36 AM
gerritbot added a comment.Apr 12 2021, 2:46 PM

Change 678604 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/core@master] Hard deprecate User ::isIP, ::getOptions

https://gerrit.wikimedia.org/r/678604

Vlad.shapik moved this task from Doing to Waiting for Review on the Platform Team Workboards (MW Expedition) board.Apr 12 2021, 2:53 PM
MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:48 PM
gerritbot added a comment.Apr 26 2021, 11:10 AM

Change 682563 had a related patch set uploaded (by Robert Vogel; author: Vlad.shapik):

[mediawiki/extensions/LDAPUserInfo@REL1_35] Avoid using User ::getOptions, ::GETOPTIONS_EXCLUDE_DEFAULTS

https://gerrit.wikimedia.org/r/682563

gerritbot added a comment.Apr 26 2021, 11:16 AM

Change 682563 merged by jenkins-bot:

[mediawiki/extensions/LDAPUserInfo@REL1_35] Avoid using User ::getOptions, ::GETOPTIONS_EXCLUDE_DEFAULTS

https://gerrit.wikimedia.org/r/682563

gerritbot added a comment.Apr 26 2021, 12:01 PM

Change 676583 merged by jenkins-bot:

[mediawiki/extensions/LDAPUserInfo@master] Avoid using User ::getOptions, ::GETOPTIONS_EXCLUDE_DEFAULTS

https://gerrit.wikimedia.org/r/676583

Vlad.shapik mentioned this in rELDU1295395ddf4e: Avoid using User ::getOptions, ::GETOPTIONS_EXCLUDE_DEFAULTS.Apr 26 2021, 12:06 PM
Osnard mentioned this in rELDU2c2d4b3c49bd: Avoid using User ::getOptions, ::GETOPTIONS_EXCLUDE_DEFAULTS.Apr 26 2021, 12:06 PM
gerritbot added a comment.Apr 26 2021, 5:06 PM

Change 678604 merged by jenkins-bot:

[mediawiki/core@master] Hard deprecate User ::isIP, ::getOptions

https://gerrit.wikimedia.org/r/678604

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 26 2021, 6:00 PM
Vlad.shapik closed this task as Resolved.Apr 26 2021, 8:14 PM
gerritbot added a comment.Apr 30 2021, 4:49 PM

Change 675522 merged by jenkins-bot:

[mediawiki/extensions/BreadCrumbs@master] Avoid using User::getOptions

https://gerrit.wikimedia.org/r/675522

gerritbot added a comment.May 10 2021, 1:48 PM

Change 676720 abandoned by Vlad.shapik:

[mediawiki/extensions/CreatedPagesList@master] Remove usages of deprecated methods in CreatedPagesListRecalculateTest

Reason:

The main goal of the patch was to replace use of User::isIP. It was done in the separate patch - Id2093751d45bdc2a29c72caf78a9500e9cd1a776.
So the patch is unuseful.

https://gerrit.wikimedia.org/r/676720

gerritbot added a comment.Dec 17 2021, 3:27 PM

Change 676831 abandoned by Umherirrender:

[mediawiki/extensions/NoBogusUserpages@master] Avoid using User::isIP

Reason:

Superseeded by Ibf3b66cad0f97f42efabee477dd95faf4b186008 which includes IPv6 as mention in the comment around the changed code.

https://gerrit.wikimedia.org/r/676831

gerritbot added a comment.Jan 3 2023, 9:53 AM

Change 676939 abandoned by D3r1ck01:

[mediawiki/extensions/ChangeAuthor@master] Avoid using User::isIP

Reason:

Done in: Idfa1d0cb05872e05e534eb128e700136d31ff203

https://gerrit.wikimedia.org/r/676939

gerritbot added a comment.Nov 20 2023, 4:09 PM

Change 676943 merged by jenkins-bot:

[mediawiki/extensions/OnlineStatusBar@master] Avoid using User::isIP

https://gerrit.wikimedia.org/r/676943

Kizule removed a project: Patch-For-Review.Nov 20 2023, 4:12 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits
  NODES
Community 2
Experiments 4
HOME 1
musik 3
Note 10
os 9
Users 1
visual 5