Filter changes trigger multiple API calls
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matthiasmullie
	Feb 26 2021, 9:15 AM

Description

Changing a filter triggers 2 API calls.
While the first one is canceled immediately, still, it has submitted a useless request to the server.
1 action resulting in multiple code trajectories (where one ends up canceling out the other) might also indicate inconsistencies. It might be totally fine, but it's worth looking into.

Acceptance criteria

Changing a filter only triggers 1 API request

Details

	Subject	Repo	Branch	Lines +/-
	Only execute 1 API call when filters change	mediawiki/extensions/WikibaseMediaInfo	master	+3 -2

Customize query in gerrit

Event Timeline

matthiasmullie created this task.Feb 26 2021, 9:15 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 26 2021, 9:15 AM

matthiasmullie moved this task from Incoming to Code Review on the Structured-Data-Backlog (Current Work) board.Feb 26 2021, 9:16 AM

Change 667124 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Only execute 1 API call when filters change

https://gerrit.wikimedia.org/r/667124

gerritbot added a project: Patch-For-Review.Feb 26 2021, 9:51 AM

Change 667124 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Only execute 1 API call when filters change

https://gerrit.wikimedia.org/r/667124

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.33; 2021-03-02).Mar 1 2021, 10:00 PM

Maintenance_bot removed a project: Patch-For-Review.Mar 1 2021, 10:10 PM

AnneT moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.Mar 3 2021, 3:39 PM

Etonkovidova moved this task from Needs QA to Verify on Production on the Structured-Data-Backlog (Current Work) board.Mar 11 2021, 8:41 PM

Etonkovidova updated the task description. (Show Details)Mar 12 2021, 1:25 AM