Page MenuHomePhabricator
Create Task
Maniphest T277367

Hatnotes not hoisted despite having correct classes
Closed, DuplicatePublic
Actions

Assigned To
None
Authored By
Esanders
Mar 13 2021, 12:32 PM
Tags
Referenced Files
None
Subscribers
Aklapper
Esanders
Izno

Description

On https://it.m.wikipedia.org/wiki/Organo_a_pompa there are two hat notes, one with the hatnote class and the other an ambox.

Both templates are using TemplateStyles which could be related.

Details

SubjectRepoBranchLines +/-
Reinstate "Rewite MoveLeadParagraphTransform based on mobile apps approach"mediawiki/extensions/MobileFrontendmaster+125 -459
Detect hatnotes which use TemplateStylesmediawiki/extensions/MobileFrontendmaster+7 -0
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Mar 13 2021, 12:32 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 13 2021, 12:32 PM
gerritbot added a comment.Mar 13 2021, 12:56 PM

Change 671556 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/MobileFrontend@master] Detect hatnotes which use TemplateStyles

https://gerrit.wikimedia.org/r/671556

gerritbot added a project: Patch-For-Review.Mar 13 2021, 12:56 PM
Esanders mentioned this in T277302: Hatnote and ambox recognition is poor and essentially only works for enwiki.Mar 14 2021, 3:10 PM
Sakretsu renamed this task from Hatnotes not hoisted depsite having correct classes to Hatnotes not hoisted despite having correct classes.Mar 14 2021, 3:28 PM
Daimona mentioned this in T277465: Apps: Hatnotes appear below paragraphs on many wikis.Mar 15 2021, 4:01 PM
Izno subscribed.Mar 15 2021, 4:40 PM

TemplateStyles tags appear as <link> as well.

Jdlrobson added a project: Web-Team-Backlog (Kanbanana-FY-2020-21).Mar 15 2021, 11:15 PM
gerritbot added a comment.Mar 16 2021, 1:06 PM

Change 672406 had a related patch set uploaded (by Esanders; owner: Daimona Eaytoy):
[mediawiki/extensions/MobileFrontend@master] Reinstate "Rewite MoveLeadParagraphTransform based on mobile apps approach"

https://gerrit.wikimedia.org/r/672406

gerritbot added a comment.Mar 16 2021, 1:07 PM

Change 671556 abandoned by Esanders:
[mediawiki/extensions/MobileFrontend@master] Detect hatnotes which use TemplateStyles

Reason:
Squashed into parent

https://gerrit.wikimedia.org/r/671556

Jdlrobson closed this task as a duplicate of T262093: MoveLeadParagraphTransformInfobox should be rewritten to be more similar to mobile apps (allow more flexibility in lead paragraph identification).Mar 16 2021, 6:42 PM
gerritbot added a comment.Apr 21 2021, 1:48 PM

Change 672406 restored by Esanders:

[mediawiki/extensions/MobileFrontend@master] Reinstate "Rewite MoveLeadParagraphTransform based on mobile apps approach"

https://gerrit.wikimedia.org/r/672406

gerritbot added a comment.Thu, Dec 12, 4:29 PM

Change #672406 abandoned by Jdlrobson:

[mediawiki/extensions/MobileFrontend@master] Reinstate "Rewite MoveLeadParagraphTransform based on mobile apps approach"

Reason:

Abandoning this given age. Next year with Parsoid roll out this will be addressed as part of an OKR/essential work stream.

https://gerrit.wikimedia.org/r/672406

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits
  NODES
HOME 1
Note 14
os 3
web 2