Change 674102 had a related patch set uploaded (by MewOphaswongse; owner: MewOphaswongse):
[mediawiki/extensions/GrowthExperiments@master] [WIP] Add a link: AI suggestions mode: update toolbar & publish button

https://gerrit.wikimedia.org/r/674102

Change 674102 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Add a link: AI suggestions mode: update toolbar & publish button

https://gerrit.wikimedia.org/r/674102

The publish button should not be active until the user has selected yes or no on at least one suggestion. If they just are skipping, the button does not activate.

If you choose a response for a suggestion, the button activates. But if you toggle the button again, the button changes to Publish. Not really possible to see without the patch for the rejection dialog (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/675776) which implements toggle buttons, but wanted to flag it as something we should fix.

for @RHo review - basically just letting you know that everything is in place (and I'll be checking the workflows again when all functionality - the toggle mode etc will be in place)

Only two, very minor notes

• It should not have any of the editing toolbar buttons.

Presently three modes, as per the mockup screenshot below are not present yet - only VE and the source editor. The VE link cannot be clicked, but a user is able to switch to the source editor. Is it correct that the goal is to have AI, VE, and the source editor links work so a user can switch between modes any time?

• On mobile, it should have an "X" in the upper left, which exits the structured task flow, putting the user on the article in read mode. When the user clicks it, they should get the confirmation dialog described in T269653: Add a link: edit mode toggle (machine suggestions & visual).

I guess it's just not implemented yet. I looked at the mockup in T269653: Add a link: edit mode toggle (machine suggestions & visual) - the confirmation dialog is supposed to be

In T278165#6959300, @Etonkovidova wrote:

for @RHo review - basically just letting you know that everything is in place (and I'll be checking the workflows again when all functionality - the toggle mode etc will be in place)

Only two, very minor notes

• It should not have any of the editing toolbar buttons.

Presently three modes, as per the mockup screenshot below are not present yet - only VE and the source editor. The VE link cannot be clicked, but a user is able to switch to the source editor. Is it correct that the goal is to have AI, VE, and the source editor links work so a user can switch between modes any time?

thanks for checking @Etonkovidova - short answer is yes the idea is that we want users to be able to switch from the AI suggestions to other editors. However, we are adding the separate dialog F33997229 as you note below to let the user know that there edits will be lost when they switch from Suggestions mode (which is different from users typically having edits kept when switch between VE and source)/

• On mobile, it should have an "X" in the upper left, which exits the structured task flow, putting the user on the article in read mode. When the user clicks it, they should get the confirmation dialog described in T269653: Add a link: edit mode toggle (machine suggestions & visual).

I guess it's just not implemented yet. I looked at the mockup in T269653: Add a link: edit mode toggle (machine suggestions & visual) - the confirmation dialog is supposed to be

not this one?

That's correct, the specific "leave suggestions mode" dialog should be shown instead.