Page MenuHomePhabricator

Special:EditGrowthConfig does not allow users to use interwiki titles
Closed, ResolvedPublic

Description

Special:EditGrowthConfig allows users to edit certain parts of the tool configuration, incl. defining where can be certain help pages found. It currently does not allow users to put in interwiki links, which are used in some parts of the configuration.

We need to make that possible with the on-wiki interface as well.

Event Timeline

kostajh triaged this task as Medium priority.Apr 14 2021, 8:19 PM

Change 693192 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/core@master] HTMLTitleTextField: Support interwiki titles

https://gerrit.wikimedia.org/r/693192

Change 693193 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] SpecialEditGrowthConfig: Support interwiki titles

https://gerrit.wikimedia.org/r/693193

Change 693192 merged by jenkins-bot:

[mediawiki/core@master] HTMLTitleTextField: Support interwiki titles

https://gerrit.wikimedia.org/r/693192

Change 693193 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] SpecialEditGrowthConfig: Support interwiki titles

https://gerrit.wikimedia.org/r/693193

Etonkovidova subscribed.

Checked in betalabs - the interwikilinks, e.g. :en:Help:Contents or c:Help:SVG will work on Special:EditGrowthConfig.

The minor issue - the hover over the interwikilinks won't display the link, e.g.

<input type="text" tabindex="0" aria-disabled="false" name="wpgeconfig-GEHelpPanelLinks-4-title" value="Wikipedie:Editujte s odvahou" maxlength="255" id="ooui-php-67" class="oo-ui-inputWidget-input" autocomplete="off" aria-expanded="false" role="combobox" aria-owns="ooui-23" aria-autocomplete="list">

Screen Shot 2021-05-25 at 6.22.35 PM.png (536×1 px, 88 KB)

But with c:Help:SVG, the link won't be displayed:

Screen Shot 2021-05-25 at 6.28.43 PM.png (482×1 px, 79 KB)

Change 699530 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/core@master] HTMLTitleTextField: include field name in deprecation warning

https://gerrit.wikimedia.org/r/699530

Change 699532 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] EditGrowthConfig: Suggested edit "Learn more" link should support interwiki

https://gerrit.wikimedia.org/r/699532

Change 699530 merged by jenkins-bot:

[mediawiki/core@master] HTMLTitleTextField: include field name in deprecation warning

https://gerrit.wikimedia.org/r/699530

Change 699532 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] EditGrowthConfig: Suggested edit "Learn more" link should support interwiki

https://gerrit.wikimedia.org/r/699532

Change 700740 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.9] EditGrowthConfig: Suggested edit "Learn more" link should support interwiki

https://gerrit.wikimedia.org/r/700740

Change 700740 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.9] EditGrowthConfig: Suggested edit "Learn more" link should support interwiki

https://gerrit.wikimedia.org/r/700740

Mentioned in SAL (#wikimedia-operations) [2021-06-23T18:35:14Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.9/extensions/GrowthExperiments/includes/Specials/SpecialEditGrowthConfig.php: rEGRE17efbafc300c: EditGrowthConfig: Suggested edit "Learn more" link should support interwiki (T279886; T285385) (duration: 01m 06s)

  NODES
Note 3
Project 7
USERS 5