Deploy new language switching functionality to logged-in users
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

NOTE: Do not deploy until blockers are resolved. Tentative date: Wednesday, April 28

Background

We are planning on deploying the new language switching functionality. We will begin with logged-in users that have opted out of legacy vector

Acceptance criteria

Stage 1: deploy to testwiki and officewiki
- Ensure full QA has been completed on these wikis
Stage 2: Deploy new language switching functionality to all users that have opted out of legacy vector
Exclude the following pilot wikis from the above:

Basque Wikipedia
French Wikipedia
French Wiktionary
Hebrew Wikipedia
Persian Wikipedia
Portuguese Wikiversity
Bengali Wikipedia
German Wikivoyage
Korean Wikipedia
Portuguese Wikipedia
Serbian Wikipedia
Turkish Wikipedia
Venetian Wikipedia
Wikimedia Incubator

Developer notes

The required config changes are:

Stage 1:

'wgVectorLanguageInHeader' => [
  'default' => [
    'logged_in' => false,
    'logged_out' => false,
  ],
  'testwiki' => [
    'logged_in' => true,
    'logged_out' => false,
  ],
  'officewiki' => [
    'logged_in' => true,
    'logged_out' => false,
  ],
],

Stage 2:

'wgVectorLanguageInHeader' => [
  'default' => [
    'logged_in' => true,
    'logged_out' => false,
  ],
  // Initially exclude those wikis in the Desktop Improvements group. See https://phabricator.wikimedia.org/T280526 for detail.
  'desktop-improvements' => [
    'logged_in' => false,
    'logged_out' => false,
  ],
],

Details

Subject	Repo	Branch	Lines +/-
Enable new language button for all logged in users outside test projects	operations/mediawiki-config	master	+19 -4
Use boolean values for wgVectorLanguageInHeader	operations/mediawiki-config	master	+4 -12
Enable language in header for office and testwiki users	operations/mediawiki-config	master	+14 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	ovasileva	T275766 Log sessionID, isAnon, editBucketCount, and selectedLanguage properties in the UniversalLanguageSelector instrument
Resolved	ovasileva	T275794 Log time on page before switching language as part of the UniversalLanguageSelector instrument
Resolved	ovasileva	T256023 [EPIC] Improve language switching capabilities
Resolved	ovasileva	T269093 Deploy new language switching location to test wikis and begin A/B test pt 1
Resolved	ovasileva	T280788 Post-deployment QA for language switching functionality
Resolved	Jdrewniak	T280526 Deploy new language switching functionality to logged-in users
Resolved	ovasileva	T277588 It should be possible to enable the new language button for logged in users
Resolved	phuedx	T275762 Instrument clicks to links in the Languages list in the sidebar
Resolved	ovasileva	T268504 [SPIKE 24hrs] Instrument language button
Resolved	ovasileva	T276248 Position language menu below language button

Event Timeline

ovasileva created this task.Apr 19 2021, 1:37 PM

Restricted Application added subscribers: Huji, revi. · View Herald TranscriptApr 19 2021, 1:37 PM

ovasileva triaged this task as High priority.Apr 19 2021, 1:37 PM

Restricted Application added a subscriber: Dereckson. · View Herald TranscriptApr 19 2021, 1:37 PM

ovasileva added a subtask: T277588: It should be possible to enable the new language button for logged in users.Apr 19 2021, 1:37 PM

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Apr 19 2021, 4:30 PM

Jdlrobson updated the task description. (Show Details)

ovasileva updated the task description. (Show Details)Apr 19 2021, 5:42 PM

phuedx updated the task description. (Show Details)Apr 19 2021, 5:44 PM

ovasileva set the point value for this task to 2.Apr 19 2021, 5:45 PM

phuedx updated the task description. (Show Details)Apr 19 2021, 5:47 PM

Jdlrobson moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Apr 20 2021, 5:47 PM

ovasileva moved this task from Ready for Development to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Apr 21 2021, 1:17 PM

ovasileva added a parent task: T280788: Post-deployment QA for language switching functionality.Apr 21 2021, 1:21 PM

ovasileva moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Apr 22 2021, 5:12 PM

ovasileva updated the task description. (Show Details)

Jdlrobson claimed this task.Apr 26 2021, 5:08 PM

Jdlrobson moved this task from Ready for Development to Doing on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

ovasileva added subtasks: T275762: Instrument clicks to links in the Languages list in the sidebar, T276248: Position language menu below language button .Apr 26 2021, 5:47 PM

Change 682757 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Enable language in header for office and testwiki logged in users

https://gerrit.wikimedia.org/r/682757

Change 682758 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Enable new language button for all logged in users outside test projects

https://gerrit.wikimedia.org/r/682758

@ovasileva while writing this patch, a few things occurred to me.

Deploying to logged in users only on Office/Test Wikipedia is a little strange. Since test.wikipedia.org is for testing and Office wiki is logged in users only, perhaps we want to deploy to all users there?

I thought that the reason for deploying on logged in users first was to allow editors time to cleanup the top of the article (coordinates and page indicators) for our _target wikis. The sooner we do this the better. What day is this planned for (do we have a task)? Note, In the event the top of the article is broken for the new language position (worse case imagine the situation where coordinates overlap language button), we can't start an A/B test as it might impact the results so the sooner we allow editors to clean up, the better.

In T280526#7035997, @Jdlrobson wrote:

@ovasileva while writing this patch, a few things occurred to me.

Deploying to logged in users only on Office/Test Wikipedia is a little strange. Since test.wikipedia.org is for testing and Office wiki is logged in users only, perhaps we want to deploy to all users there?

Yup, stage 1 refers to all users on these wikis. Stage 2 is for people that have opted in.

I thought that the reason for deploying on logged in users first was to allow editors time to cleanup the top of the article (coordinates and page indicators) for our _target wikis. The sooner we do this the better. What day is this planned for (do we have a task)? Note, In the event the top of the article is broken for the new language position (worse case imagine the situation where coordinates overlap language button), we can't start an A/B test as it might impact the results so the sooner we allow editors to clean up, the better.

This is stage 2, which would be covered in this task. If we can get stage 1 done today, stage 2 would follow Thursday

Jdlrobson removed Jdlrobson as the assignee of this task.Apr 27 2021, 5:58 PM

Jdlrobson moved this task from Blocked on Others to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

Change 682757 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable language in header for office and testwiki users

https://gerrit.wikimedia.org/r/682757

Change 683036 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Drop default value for wgVectorLanguageInHeader

https://gerrit.wikimedia.org/r/683036

Change 683036 merged by jenkins-bot:

[operations/mediawiki-config@master] Use boolean values for wgVectorLanguageInHeader

https://gerrit.wikimedia.org/r/683036

Mentioned in SAL (#wikimedia-operations) [2021-04-27T18:32:29Z] <urbanecm@deploy1002> Synchronized wmf-config/InitialiseSettings.php: 91a85f2: ac770bf: Enable language in header for office and testwiki users (T280526) (duration: 01m 19s)

Jdlrobson moved this task from Code Review to Blocked on Others on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Apr 27 2021, 6:49 PM

Not sure where to report this, but I noticed on test wiki that there is an escaping issue (32 langues) that is visible in French: https://test.wikipedia.org/wiki/Main_Page?uselang=fr

Jdlrobson mentioned this in T280788: Post-deployment QA for language switching functionality.Apr 28 2021, 4:19 PM

@Jdrewniak will deploy Tuesday 11AM UTC

Jdlrobson moved this task from Code Review to Doing on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.May 4 2021, 10:08 PM

Change 682758 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable new language button for all logged in users outside test projects

https://gerrit.wikimedia.org/r/682758

Maintenance_bot removed a project: Patch-For-Review.May 5 2021, 11:10 AM

Mentioned in SAL (#wikimedia-operations) [2021-05-05T11:10:59Z] <urbanecm@deploy1002> Synchronized wmf-config/InitialiseSettings.php: 289dc34feeb0703bb45f4a71c149cd607ef26455: Enable new language button for all logged in users outside test projects (T280526) (duration: 02m 24s)