Page MenuHomePhabricator
Create Task
Maniphest T281167

1.38.0-wmf.3 deployment blockers
Closed, ResolvedPublic5 Estimated Story PointsRelease
Actions

Assigned To
brennen
Authored By
thcipriani
Apr 26 2021, 3:15 PM
Tags
Referenced Files
None
Subscribers
Aklapper
DannyS712
Jdforrester-WMF
Legoktm
• Pchelolo
thcipriani
Zabe

Details

Backup Train Conductor
jeena
Release Version
1.38.0-wmf.3
Release Date
Oct 4 2021, 12:00 AM

2021 week 40 1.38-wmf.3 Changes wmf/1.38.0-wmf.3

This MediaWiki Train Deployment is scheduled for the week of Monday, October 4th:

Monday October 4thTuesday, October 5thWednesday, October 6thThursday, October 7thFriday
Backports only.Branch wmf.3 and deploy to Group 0 Wikis.Deploy wmf.3 to Group 1 Wikis.Deploy wmf.3 to all Wikis.No deployments on fridays

How this works

  • Any serious bugs affecting wmf.3 should be added as subtasks beneath this one.
  • Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
  • If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
  • If you have a risky change in this week's train add a comment to this task using the Risky patch template
  • For more info about deployment blockers, see Holding the train.

Related Links

Other Deployments

Previous: 1.38.0-wmf.2
Next: 1.38.0-wmf.4
SubjectRepoBranchLines +/-
Revert "all wikis to 1.38.0-wmf.3 refs T281167"operations/mediawiki-configmaster+319 -319
Revert "group0 wikis to 1.38.0-wmf.3 refs T281167"operations/mediawiki-configmaster+128 -128
Customize query in gerrit

Related Objects
Search...

Event Timeline

thcipriani created this task.Apr 26 2021, 3:15 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 26 2021, 3:15 PM
thcipriani renamed this task from 1.37.0-wmf.26 deployment blockers to 1.38.0-wmf.3 deployment blockers.Aug 24 2021, 6:51 PM
thcipriani changed Release Version from 1.37.0-wmf.26 to 1.38.0-wmf.3.
thcipriani assigned this task to brennen.Aug 25 2021, 4:39 PM
thcipriani triaged this task as Medium priority.
thcipriani updated Other Assignee, added: jeena.
thcipriani set the point value for this task to 5.
thcipriani added a project: Release-Engineering-Team (Doing).
Umherirrender added a subtask: T292374: CI failure on TemplateStyles: Still uses removed Content::getHtml().Oct 3 2021, 8:56 PM
• Pchelolo subscribed.Oct 4 2021, 4:42 PM

T280806 will likely show up during a train deploy. We're removing old deprecated Action API parameters, and after many many many announcements there's still a bunch of usages left. It's possible there will be no complaints and all the leftover requests are by some not-used-anymore bots, but if there's a breakage, these 2 changes return the removed parameters.

https://gerrit.wikimedia.org/r/c/mediawiki/core/+/724792
https://gerrit.wikimedia.org/r/c/mediawiki/core/+/724791

Please ping me if something shows up.

Umherirrender closed subtask T292374: CI failure on TemplateStyles: Still uses removed Content::getHtml() as Resolved.Oct 4 2021, 5:49 PM
Stashbot added a comment.Oct 5 2021, 4:47 PM

Mentioned in SAL (#wikimedia-operations) [2021-10-05T16:47:29Z] <brennen> coordinated with deployment backup and starting train prep for 1.38.0-wmf.3 (T281167), branched at 65279490f82c785181b8b6961e40901a4aaafca4

Stashbot added a comment.Oct 5 2021, 4:56 PM

Mentioned in SAL (#wikimedia-operations) [2021-10-05T16:56:15Z] <brennen> successfully applied security patches for 1.38.0-wmf.3 train (T281167)

gerritbot added a comment.Oct 5 2021, 5:09 PM

Change 726664 had a related patch set uploaded (by Brennen Bearnes; author: Brennen Bearnes):

[operations/mediawiki-config@master] testwikis wikis to 1.38.0-wmf.3 refs T281167

https://gerrit.wikimedia.org/r/726664

gerritbot added a project: Patch-For-Review.Oct 5 2021, 5:09 PM

Change 726664 merged by jenkins-bot:

[operations/mediawiki-config@master] testwikis wikis to 1.38.0-wmf.3 refs T281167

https://gerrit.wikimedia.org/r/726664

Stashbot added a comment.Oct 5 2021, 5:09 PM

Mentioned in SAL (#wikimedia-operations) [2021-10-05T17:09:54Z] <brennen@deploy1002> Started scap: testwikis wikis to 1.38.0-wmf.3 refs T281167

brennen added a project: User-brennen.Oct 5 2021, 5:12 PM
brennen moved this task from Backlog to Doing/Involved on the User-brennen board.
Stashbot added a comment.Oct 5 2021, 5:55 PM

Mentioned in SAL (#wikimedia-operations) [2021-10-05T17:55:53Z] <brennen@deploy1002> Finished scap: testwikis wikis to 1.38.0-wmf.3 refs T281167 (duration: 45m 59s)

Stashbot added a comment.Oct 5 2021, 6:21 PM

Mentioned in SAL (#wikimedia-operations) [2021-10-05T18:21:20Z] <brennen> 1.38.0-wmf.3 (T281167): pruning old branches, starting with 1.37.0-wmf.21, proceeeding to 1.37.0-wmf.23 if time allows

gerritbot added a comment.Oct 5 2021, 7:00 PM

Change 726676 had a related patch set uploaded (by Brennen Bearnes; author: Brennen Bearnes):

[operations/mediawiki-config@master] group0 wikis to 1.38.0-wmf.3 refs T281167

https://gerrit.wikimedia.org/r/726676

gerritbot added a comment.Oct 5 2021, 7:01 PM

Change 726676 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 wikis to 1.38.0-wmf.3 refs T281167

https://gerrit.wikimedia.org/r/726676

Stashbot added a comment.Oct 5 2021, 7:03 PM

Mentioned in SAL (#wikimedia-operations) [2021-10-05T19:03:05Z] <brennen@deploy1002> rebuilt and synchronized wikiversions files: group0 wikis to 1.38.0-wmf.3 refs T281167

jeena added a subtask: T292570: ImageHistoryPseudoPager: PHP Notice: Undefined offset: [n].Oct 5 2021, 7:13 PM
gerritbot added a comment.Oct 5 2021, 8:45 PM

Change 726683 had a related patch set uploaded (by Brennen Bearnes; author: Brennen Bearnes):

[operations/mediawiki-config@master] group0 wikis to 1.38.0-wmf.3 refs T281167

https://gerrit.wikimedia.org/r/726683

gerritbot added a comment.Oct 5 2021, 8:46 PM

Change 726683 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 wikis to 1.38.0-wmf.3 refs T281167

https://gerrit.wikimedia.org/r/726683

Stashbot added a comment.Oct 5 2021, 8:47 PM

Mentioned in SAL (#wikimedia-operations) [2021-10-05T20:47:52Z] <brennen@deploy1002> rebuilt and synchronized wikiversions files: group0 wikis to 1.38.0-wmf.3 refs T281167

DannyS712 subscribed.Oct 5 2021, 8:50 PM

@brennen would it be possible for the commits that revert/rollback the train to also get tagged with this task? Otherwise its confusing that there are two entries above for rolling group0 to wmf.3 with no indication that they were moved back to wmf.2 in between

brennen added a comment.Oct 5 2021, 8:56 PM

@DannyS712 That's a reasonable enough ask, though this is all still manual and tends to vary some between deployers. I've added a note about adding the blocker task to the Bug: field for the revert commit:

https://wikitech.wikimedia.org/wiki/Heterogeneous_deployment/Train_deploys#Rollback

I think I also sometimes log the action beforehand, though it's easy to forget.

brennen removed a subtask: T292570: ImageHistoryPseudoPager: PHP Notice: Undefined offset: [n].Oct 5 2021, 8:59 PM
brennen mentioned this in T292590: TypeError: Argument 1 passed to MediaWiki\CommentFormatter\CommentItem::__construct() must be of the type string, null given.Oct 5 2021, 9:54 PM
brennen added a subtask: T292590: TypeError: Argument 1 passed to MediaWiki\CommentFormatter\CommentItem::__construct() must be of the type string, null given.Oct 5 2021, 10:00 PM
Stashbot added a comment.Oct 5 2021, 10:20 PM

Mentioned in SAL (#wikimedia-operations) [2021-10-05T22:20:09Z] <brennen> 1.38.0-wmf.3 (T281167) rolling back to testwikis for the day; will revisit in US-morning

gerritbot added a comment.Oct 5 2021, 10:25 PM

Change 726700 had a related patch set uploaded (by Brennen Bearnes; author: Brennen Bearnes):

[operations/mediawiki-config@master] Revert \"group0 wikis to 1.38.0-wmf.3 refs T281167\"

https://gerrit.wikimedia.org/r/726700

gerritbot added a comment.Oct 5 2021, 10:26 PM

Change 726700 merged by jenkins-bot:

[operations/mediawiki-config@master] Revert \"group0 wikis to 1.38.0-wmf.3 refs T281167\"

https://gerrit.wikimedia.org/r/726700

Stashbot added a comment.Oct 6 2021, 3:45 PM

Mentioned in SAL (#wikimedia-operations) [2021-10-06T15:45:47Z] <brennen> 1.38.0-wmf.3 train (T281167): proceeding to deploy backports for T292589

Stashbot mentioned this in T292589: CI failure on Scribunto: Still uses removed ParserOptions::getUser().Oct 6 2021, 3:45 PM
brennen closed subtask T292590: TypeError: Argument 1 passed to MediaWiki\CommentFormatter\CommentItem::__construct() must be of the type string, null given as Resolved.Oct 6 2021, 4:42 PM
brennen closed subtask T292589: CI failure on Scribunto: Still uses removed ParserOptions::getUser() as Resolved.
Stashbot added a comment.Oct 6 2021, 4:43 PM

Mentioned in SAL (#wikimedia-operations) [2021-10-06T16:43:08Z] <brennen> 1.38.0-wmf.3 train (T281167): unblocked, rolling to group0

gerritbot added a comment.Oct 6 2021, 4:45 PM

Change 726937 had a related patch set uploaded (by Brennen Bearnes; author: Brennen Bearnes):

[operations/mediawiki-config@master] group0 wikis to 1.38.0-wmf.3 refs T281167

https://gerrit.wikimedia.org/r/726937

gerritbot added a comment.Oct 6 2021, 4:45 PM

Change 726937 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 wikis to 1.38.0-wmf.3 refs T281167

https://gerrit.wikimedia.org/r/726937

Stashbot added a comment.Oct 6 2021, 4:47 PM

Mentioned in SAL (#wikimedia-operations) [2021-10-06T16:47:19Z] <brennen@deploy1002> rebuilt and synchronized wikiversions files: group0 wikis to 1.38.0-wmf.3 refs T281167

Stashbot added a comment.Oct 6 2021, 7:01 PM

Mentioned in SAL (#wikimedia-operations) [2021-10-06T19:01:11Z] <brennen> 1.38.0-wmf.3 train (T281167): still unblocked after triage meeting, rolling to group1

gerritbot added a comment.Oct 6 2021, 7:01 PM

Change 726977 had a related patch set uploaded (by Brennen Bearnes; author: Brennen Bearnes):

[operations/mediawiki-config@master] group1 wikis to 1.38.0-wmf.3 refs T281167

https://gerrit.wikimedia.org/r/726977

gerritbot added a comment.Oct 6 2021, 7:02 PM

Change 726977 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 wikis to 1.38.0-wmf.3 refs T281167

https://gerrit.wikimedia.org/r/726977

Stashbot added a comment.Oct 6 2021, 7:04 PM

Mentioned in SAL (#wikimedia-operations) [2021-10-06T19:04:20Z] <brennen@deploy1002> rebuilt and synchronized wikiversions files: group1 wikis to 1.38.0-wmf.3 refs T281167

Stashbot added a comment.Oct 6 2021, 7:05 PM

Mentioned in SAL (#wikimedia-operations) [2021-10-06T19:05:23Z] <brennen@deploy1002> Synchronized php: group1 wikis to 1.38.0-wmf.3 refs T281167 (duration: 01m 03s)

brennen mentioned this in T292667: WikidataPageBanner: Cannot instantiate interface Wikibase\DataModel\Entity\PropertyId.Oct 6 2021, 7:15 PM
brennen added a subtask: T292667: WikidataPageBanner: Cannot instantiate interface Wikibase\DataModel\Entity\PropertyId.Oct 6 2021, 7:18 PM
brennen added a comment.Oct 6 2021, 11:14 PM

End-of-workday status: Logs generally quiet, with the exception of T292667, which has a patch and reviewers. I expect that can likely be deployed before tomorrow's train window.

Jdforrester-WMF subscribed.Oct 7 2021, 2:38 AM

Note that I've upgraded the CI world to composer 2.x, which works fine, but which brought along a new version of wikidiff2 with a couple of necessary fixes; these fixes are cherry-picked to wmf.3 (and wmf.2) and ready to merge/deploy if anything needs it.

Zabe closed subtask T292667: WikidataPageBanner: Cannot instantiate interface Wikibase\DataModel\Entity\PropertyId as Resolved.Oct 7 2021, 11:46 AM
Stashbot added a comment.Oct 7 2021, 7:03 PM

Mentioned in SAL (#wikimedia-operations) [2021-10-07T19:03:27Z] <brennen> 1.38.0-wmf.3 train (T281167): unblocked, rolling to all wikis

gerritbot added a comment.Oct 7 2021, 7:04 PM

Change 727468 had a related patch set uploaded (by Brennen Bearnes; author: Brennen Bearnes):

[operations/mediawiki-config@master] all wikis to 1.38.0-wmf.3 refs T281167

https://gerrit.wikimedia.org/r/727468

gerritbot added a comment.Oct 7 2021, 7:05 PM

Change 727468 merged by jenkins-bot:

[operations/mediawiki-config@master] all wikis to 1.38.0-wmf.3 refs T281167

https://gerrit.wikimedia.org/r/727468

Stashbot added a comment.Oct 7 2021, 7:07 PM

Mentioned in SAL (#wikimedia-operations) [2021-10-07T19:07:08Z] <brennen@deploy1002> rebuilt and synchronized wikiversions files: all wikis to 1.38.0-wmf.3 refs T281167

brennen mentioned this in T292777: MWException: Invalid name 'wpgadget-Special:WhatLinksHere_action_links' passed to HTMLFormField::__construct.Oct 7 2021, 7:18 PM
gerritbot added a comment.Oct 7 2021, 7:20 PM

Change 727470 had a related patch set uploaded (by Brennen Bearnes; author: Brennen Bearnes):

[operations/mediawiki-config@master] Revert \"all wikis to 1.38.0-wmf.3 refs T281167\"

https://gerrit.wikimedia.org/r/727470

brennen added a subtask: T292777: MWException: Invalid name 'wpgadget-Special:WhatLinksHere_action_links' passed to HTMLFormField::__construct.Oct 7 2021, 7:20 PM
gerritbot added a comment.Oct 7 2021, 7:20 PM

Change 727470 merged by jenkins-bot:

[operations/mediawiki-config@master] Revert \"all wikis to 1.38.0-wmf.3 refs T281167\"

https://gerrit.wikimedia.org/r/727470

Stashbot added a comment.Oct 7 2021, 7:33 PM

Mentioned in SAL (#wikimedia-operations) [2021-10-07T19:33:46Z] <brennen> 1.38.0-wmf.3 train (T281167): variously blocked, rolling back to testwikis for safe deploy of backports

Stashbot added a comment.Oct 7 2021, 7:37 PM

Mentioned in SAL (#wikimedia-operations) [2021-10-07T19:37:36Z] <brennen@deploy1002> rebuilt and synchronized wikiversions files: Revert all wikis to 1.38.0-wmf.2 (T281167)

taavi added a subtask: T292779: Account problems (Wrong provider ..\CentralAuth\Session\CentralAuthSessionProvider !== CentralAuthSessionProvider).Oct 7 2021, 7:38 PM
Krinkle closed subtask T292777: MWException: Invalid name 'wpgadget-Special:WhatLinksHere_action_links' passed to HTMLFormField::__construct as Resolved.Oct 7 2021, 8:22 PM
gerritbot added a comment.Oct 7 2021, 8:33 PM

Change 727525 had a related patch set uploaded (by Brennen Bearnes; author: Brennen Bearnes):

[operations/mediawiki-config@master] all wikis to 1.38.0-wmf.2 refs T281167

https://gerrit.wikimedia.org/r/727525

gerritbot added a comment.Oct 7 2021, 8:34 PM

Change 727525 merged by jenkins-bot:

[operations/mediawiki-config@master] all wikis to 1.38.0-wmf.2 refs T281167

https://gerrit.wikimedia.org/r/727525

Stashbot added a comment.Oct 7 2021, 8:37 PM

Mentioned in SAL (#wikimedia-operations) [2021-10-07T20:37:49Z] <brennen@deploy1002> rebuilt and synchronized wikiversions files: all wikis to 1.38.0-wmf.2 refs T281167

Zabe closed subtask T292779: Account problems (Wrong provider ..\CentralAuth\Session\CentralAuthSessionProvider !== CentralAuthSessionProvider) as Resolved.Oct 7 2021, 9:02 PM
brennen mentioned this in T292797: CommentFormatter: TypeError: Argument 1 passed to MediaWiki\CommentFormatter\CommentParser::preprocess() must be of the type string, null given.Oct 7 2021, 10:28 PM
Zabe subscribed.Oct 8 2021, 9:58 AM
brennen closed this task as Resolved.Oct 8 2021, 4:21 PM

At all wikis overnight, things seem pretty chill in logs. Optimistically calling this resolved.

Legoktm subscribed.Oct 8 2021, 7:15 PM

There's something wrong with history page ordering: T292791: Oldest revisions not listed in the correct order.

brennen reopened this task as Open.Oct 8 2021, 7:16 PM
brennen closed this task as Resolved.Oct 19 2021, 6:35 AM
brennen moved this task from Doing/Involved to Done or Declined on the User-brennen board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits
  NODES
composer 1
HOME 1
Note 3
os 13