Fix deprecated \Hooks::run call in \Wikibase\Client\includes\Changes\ChangeHandler
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Michael
	Sep 13 2021, 10:03 AM

Description

\Hooks::run is deprecated. \MediaWiki\HookContainer\HookContainer::run() should be used instead

See T240307: Hook container with strong types and DI for context.

Create a service holding the hook container i.e. WikibaseClient.HookRunner and inject that instead.

see [T254558] for examples

Details

	Subject	Repo	Branch	Lines +/-
	Create service to hold the hook container	mediawiki/extensions/Wikibase	master	+175 -11
	Fix deprecated Hooks::run() call in ChangeHandler	mediawiki/extensions/Wikibase	master	+22 -13

Customize query in gerrit

Related Objects

Mentioned Here: T254558: Update Nuke hook running to use HookContainer
T240307: Hook container with strong types and DI

Event Timeline

Michael created this task.Sep 13 2021, 10:03 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 13 2021, 10:03 AM

dang renamed this task from Fix deprecated \Hooks::run call in \Wikibase\Client\Changes\ChangeHandler to Fix deprecated \Hooks::run call in \Wikibase\Client\includes\Changes\ChangeHandler.Sep 13 2021, 2:43 PM

Michael moved this task from Backlog to Doing on the Wikibase change dispatching scripts to jobs board.Sep 16 2021, 3:06 PM

dang claimed this task.Sep 20 2021, 12:23 PM

Change 722642 had a related patch set uploaded (by Dat Nguyen; author: Dat Nguyen):

[mediawiki/extensions/Wikibase@master] [DNM][WIP]Fix deprecated Hooks::run() call in ChangeHandler

https://gerrit.wikimedia.org/r/722642

gerritbot added a project: Patch-For-Review.Sep 21 2021, 3:31 PM

dang moved this task from Doing to Needs Review on the Wikibase change dispatching scripts to jobs board.Sep 29 2021, 1:13 PM

Change 722642 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Fix deprecated Hooks::run() call in ChangeHandler

https://gerrit.wikimedia.org/r/722642

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.3; 2021-10-05).Sep 29 2021, 4:00 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 29 2021, 4:10 PM

dang moved this task from Needs Review to Done on the Wikibase change dispatching scripts to jobs board.Oct 1 2021, 1:12 PM

Change 726918 had a related patch set uploaded (by Dat Nguyen; author: Dat Nguyen):

[mediawiki/extensions/Wikibase@master] [DNM][WIP]Create service to hold the hook container

https://gerrit.wikimedia.org/r/726918

gerritbot added a project: Patch-For-Review.Oct 6 2021, 2:55 PM

dang updated the task description. (Show Details)Oct 8 2021, 1:07 PM

Michael moved this task from Done to Doing on the Wikibase change dispatching scripts to jobs board.Oct 8 2021, 2:24 PM

dang moved this task from Doing to Needs Review on the Wikibase change dispatching scripts to jobs board.Oct 20 2021, 4:11 PM

Change 726918 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Create service to hold the hook container

https://gerrit.wikimedia.org/r/726918

Lucas_Werkmeister_WMDE closed this task as Resolved.Oct 21 2021, 11:19 AM

Lucas_Werkmeister_WMDE moved this task from Needs Review to Done on the Wikibase change dispatching scripts to jobs board.

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.6; 2021-10-26); removed MW-1.38-notes (1.38.0-wmf.3; 2021-10-05).Oct 21 2021, 12:00 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 21 2021, 12:10 PM

Fix deprecated \Hooks::run call in \Wikibase\Client\includes\Changes\ChangeHandlerClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Fix deprecated \Hooks::run call in \Wikibase\Client\includes\Changes\ChangeHandler
Closed, ResolvedPublic
Actions