Page MenuHomePhabricator
Create Task
Maniphest T290975

Synchronize scroll and focus when template dialog is in narrow-screen mode
Closed, ResolvedPublic5 Estimated Story Points
Actions

Assigned To
thiemowmde
Authored By
thiemowmde
Sep 14 2021, 2:51 PM
Tags
Referenced Files
None
Subscribers
Aklapper
awight
ECohen_WMDE
lilients_WMDE
thiemowmde

Description

On narrow (mobile) screens, the template dialog collapses so that only one side is shown at a time. The button at the bottom flips between the two sides. This ticket is exclusively about this mode.

  • When I enable a parameter in the sidebar and flip to the content pane,
    • the parameter should scroll into view at the top of the screen. The parameter label should be at the top, with the description and input field directly below. This should work the same way as T299036: VE Dialog: Clicking template or parameter name scrolls it to top of dialog
    • ... and (if narrow + desktop) the text cursor should be in the input field for the parameter I just added
    • ... but (if narrow + mobile) the input field should not be focused
  • Same when I click on a parameter name that's already checked.
  • Same when I press enter on the parameter.
  • When I put the text cursor in an input field in the content pane, and then flip to the sidebar, the corresponding item in the sidebar should be highlighted.
    • … and scroll into view.
    • also for wikitext inputs

Related work already done via T289043: [Epic] Synchronize scroll, highlight, and focus in new VE template dialog sidebar and content pane.

Other possibly related tickets:

Details

SubjectRepoBranchLines +/-
Focus the input after switching to the content panemediawiki/extensions/VisualEditormaster+7 -2
Scroll even if sidebar selection hasn't changedmediawiki/extensions/VisualEditormaster+3 -3
[WIP] Make it possible to unset the pageoojs/uimaster+5 -2
Update OOUI to v0.42.1mediawiki/coremaster+281 -212
Remove misplaced .selectFirstSelectablePage() calls in BookletLayoutoojs/uimaster+6 -6
Sync panels in narrow-view modemediawiki/extensions/VisualEditormaster+26 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

thiemowmde created this task.Sep 14 2021, 2:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 14 2021, 2:51 PM
thiemowmde added a subtask: T289043: [Epic] Synchronize scroll, highlight, and focus in new VE template dialog sidebar and content pane.Sep 14 2021, 2:52 PM
awight renamed this task from Synchronize scroll positions when template dialog is in collapsed (mobile) mode to Synchronize scroll and focus when template dialog is in collapsed (mobile) mode.Sep 15 2021, 7:10 AM
ECohen_WMDE moved this task from Backlog to In preparation on the WMDE-Templates-FocusArea board.Sep 15 2021, 8:10 AM
thiemowmde mentioned this in T291067: Wrong focus when adding a new template in mobile view.Sep 15 2021, 10:25 AM
awight renamed this task from Synchronize scroll and focus when template dialog is in collapsed (mobile) mode to Synchronize scroll and focus when template dialog is in narrow-screen mode.Sep 15 2021, 12:04 PM
awight added a parent task: T291067: Wrong focus when adding a new template in mobile view.Sep 15 2021, 12:11 PM
awight moved this task from In preparation to Ready for story time on the WMDE-Templates-FocusArea board.Sep 15 2021, 12:17 PM
thiemowmde updated the task description. (Show Details)Sep 15 2021, 1:24 PM
thiemowmde set the point value for this task to 5.Sep 15 2021, 1:27 PM
Lena_WMDE moved this task from Ready for story time to Ready for pickup on the WMDE-Templates-FocusArea board.Sep 15 2021, 1:54 PM
Lena_WMDE added a project: WMDE-TechWish-Sprint-2021-09-15.
Lena_WMDE moved this task from Ready for pickup to In sprint on the WMDE-Templates-FocusArea board.Sep 15 2021, 1:56 PM
Andrew-WMDE mentioned this in T291080: Synchronize right pane on sidebar focus in mobile view.Sep 17 2021, 2:49 PM
awight claimed this task.Sep 20 2021, 10:39 AM
awight moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2021-09-15 board.
matmarex moved this task from To Triage to Triaged on the VisualEditor board.Sep 20 2021, 12:30 PM
lilients_WMDE mentioned this in T289043: [Epic] Synchronize scroll, highlight, and focus in new VE template dialog sidebar and content pane.Sep 20 2021, 2:09 PM
gerritbot added a comment.Sep 21 2021, 2:18 PM

Change 722626 had a related patch set uploaded (by Awight; author: Awight):

[oojs/ui@master] [WIP] Make it possible to unset the page

https://gerrit.wikimedia.org/r/722626

gerritbot added a project: Patch-For-Review.Sep 21 2021, 2:18 PM
gerritbot added a comment.Sep 21 2021, 2:21 PM

Change 722627 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] [WIP] narrow mode fixes

https://gerrit.wikimedia.org/r/722627

awight removed awight as the assignee of this task.Sep 24 2021, 10:04 AM
awight moved this task from Doing to Review on the WMDE-TechWish-Sprint-2021-09-15 board.
awight updated the task description. (Show Details)Sep 24 2021, 10:07 AM

Everything but left-to-right focus should work. That behavior has eluded me so far, it suffers from some optimization in oojs which short-circuits focus when the library detects it is already applied.

awight mentioned this in T291381: Scroll sidebar on focusing wikitext input.Sep 24 2021, 11:22 AM
gerritbot added a comment.Sep 24 2021, 7:17 PM

Change 723611 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[oojs/ui@master] Remove misplaced .selectFirstSelectablePage() calls in BookletLayout

https://gerrit.wikimedia.org/r/723611

gerritbot added a comment.Sep 27 2021, 9:04 AM

Change 722627 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Sync panels in narrow-view mode

https://gerrit.wikimedia.org/r/722627

awight moved this task from Review to Demo on the WMDE-TechWish-Sprint-2021-09-15 board.Sep 27 2021, 9:35 AM
ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.2; 2021-09-28).Sep 27 2021, 10:00 AM
ECohen_WMDE moved this task from Demo to Done on the WMDE-TechWish-Sprint-2021-09-15 board.Sep 28 2021, 8:08 AM
gerritbot added a comment.Oct 8 2021, 9:43 PM

Change 723611 merged by jenkins-bot:

[oojs/ui@master] Remove misplaced .selectFirstSelectablePage() calls in BookletLayout

https://gerrit.wikimedia.org/r/723611

gerritbot added a comment.Nov 4 2021, 2:10 AM

Change 736621 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] Update OOUI to v0.42.1

https://gerrit.wikimedia.org/r/736621

gerritbot added a comment.Nov 4 2021, 9:16 PM

Change 736621 merged by jenkins-bot:

[mediawiki/core@master] Update OOUI to v0.42.1

https://gerrit.wikimedia.org/r/736621

Lena_WMDE moved this task from In sprint to In preparation on the WMDE-Templates-FocusArea board.Jun 1 2022, 12:01 PM
ECohen_WMDE updated the task description. (Show Details)Jun 15 2022, 8:42 AM
ECohen_WMDE updated the task description. (Show Details)Jun 15 2022, 8:48 AM
awight added a subtask: T289049: Disconnect old sidebar from VE template dialog.Jun 15 2022, 9:31 AM
Lena_WMDE removed a subtask: T289043: [Epic] Synchronize scroll, highlight, and focus in new VE template dialog sidebar and content pane.Jun 23 2022, 8:20 AM
Lena_WMDE added a parent task: T289043: [Epic] Synchronize scroll, highlight, and focus in new VE template dialog sidebar and content pane.
ECohen_WMDE subscribed.Jun 23 2022, 8:26 AM

Note: this ticket might get resolved with T299036: VE Dialog: Clicking template or parameter name scrolls it to top of dialog

Lena_WMDE moved this task from In preparation to Ready for pickup on the WMDE-Templates-FocusArea board.Jun 23 2022, 8:35 AM
awight closed subtask T289049: Disconnect old sidebar from VE template dialog as Resolved.Jul 4 2022, 1:58 PM
WMDE-Fisch mentioned this in T312015: Regression: switching to the content pane in narrow mode doesn't focus selected input, loses selection..Jul 4 2022, 7:58 PM
awight updated the task description. (Show Details)Jul 5 2022, 8:15 AM
awight claimed this task.Jul 5 2022, 11:45 AM
awight removed awight as the assignee of this task.
awight moved this task from Ready for pickup to In sprint on the WMDE-Templates-FocusArea board.
awight added a project: WMDE-TechWish-Sprint-2022-06-22.
awight moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2022-06-22 board.
awight moved this task from Doing to Demo on the WMDE-TechWish-Sprint-2022-06-22 board.
gerritbot added a comment.Jul 6 2022, 7:18 AM

Change 722626 abandoned by WMDE-Fisch:

[oojs/ui@master] [WIP] Make it possible to unset the page

Reason:

Not needed anymore since we forked BookletLayout for our needs.

https://gerrit.wikimedia.org/r/722626

awight added a comment.Jul 6 2022, 8:09 AM

One last broken case: clicking into a wikitext input in the content pane doesn't select or scroll the sidebar when switching back.

awight moved this task from Demo to Sprint Backlog on the WMDE-TechWish-Sprint-2022-06-22 board.Jul 6 2022, 8:10 AM
awight added a project: WMDE-TechWish-Sprint-2022-07-06.Jul 6 2022, 8:32 AM
ECohen_WMDE updated the task description. (Show Details)Jul 6 2022, 8:54 AM

Updated task to reflect the mobile distinction discussed in sprint review (I hope it's clear!)

awight updated the task description. (Show Details)Jul 6 2022, 11:12 AM
awight updated the task description. (Show Details)
awight claimed this task.Jul 6 2022, 12:08 PM
awight moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2022-06-22 board.
gerritbot added a comment.Jul 6 2022, 12:49 PM

Change 811702 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] Focus the input after switching to the content pane

https://gerrit.wikimedia.org/r/811702

gerritbot added a comment.Jul 6 2022, 1:00 PM

Change 811710 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] Scroll even if sidebar selection hasn't changed

https://gerrit.wikimedia.org/r/811710

awight removed awight as the assignee of this task.Jul 6 2022, 1:01 PM
awight moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2022-07-06 board.
gerritbot added a comment.Jul 6 2022, 1:38 PM

Change 811710 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Scroll even if sidebar selection hasn't changed

https://gerrit.wikimedia.org/r/811710

gerritbot added a comment.Jul 6 2022, 2:19 PM

Change 811702 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Focus the input after switching to the content pane

https://gerrit.wikimedia.org/r/811702

lilients_WMDE updated the task description. (Show Details)Jul 7 2022, 1:52 PM
lilients_WMDE moved this task from Tech Review to Demo on the WMDE-TechWish-Sprint-2022-07-06 board.
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.21; 2022-07-18).Jul 12 2022, 3:01 AM
awight moved this task from Demo to Done on the WMDE-TechWish-Sprint-2022-07-06 board.Jul 19 2022, 8:55 AM

Check how it looks after any potential changes to remove scrolling animation.

thiemowmde closed this task as Resolved.Jul 20 2022, 8:12 AM
thiemowmde claimed this task.
WMDE-Fisch removed a parent task: T291067: Wrong focus when adding a new template in mobile view.Aug 2 2022, 12:29 PM
WMDE-Fisch added a subtask: T291067: Wrong focus when adding a new template in mobile view.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits
  NODES
Note 6
Project 6