InvalidArgumentException: Invalid IP address
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

mwversion: 1.38.0-wmf.1
reqId: edbca775-0f0a-4bab-b2e6-d6f5b7f99d78
Find reqId in Logstash
Find normalized_message in Logstash

normalized_message

[{reqId}] {exception_url}   InvalidArgumentException: Invalid IP address

exception.trace

from /srv/mediawiki/php-1.38.0-wmf.1/includes/user/UserFactory.php(115)
#0 /srv/mediawiki/php-1.38.0-wmf.1/extensions/MobileFrontend/includes/specials/SpecialMobileContributions.php(73): MediaWiki\User\UserFactory->newAnonymous(string)
#1 /srv/mediawiki/php-1.38.0-wmf.1/extensions/MobileFrontend/includes/specials/MobileSpecialPage.php(75): SpecialMobileContributions->executeWhenAvailable(string)
#2 /srv/mediawiki/php-1.38.0-wmf.1/extensions/MobileFrontend/includes/specials/MobileSpecialPageFeed.php(30): MobileSpecialPage->execute(string)
#3 /srv/mediawiki/php-1.38.0-wmf.1/includes/specialpage/SpecialPage.php(647): MobileSpecialPageFeed->execute(string)
#4 /srv/mediawiki/php-1.38.0-wmf.1/includes/specialpage/SpecialPageFactory.php(1367): SpecialPage->run(string)
#5 /srv/mediawiki/php-1.38.0-wmf.1/includes/MediaWiki.php(314): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#6 /srv/mediawiki/php-1.38.0-wmf.1/includes/MediaWiki.php(925): MediaWiki->performRequest()
#7 /srv/mediawiki/php-1.38.0-wmf.1/includes/MediaWiki.php(559): MediaWiki->main()
#8 /srv/mediawiki/php-1.38.0-wmf.1/index.php(53): MediaWiki->run()
#9 /srv/mediawiki/php-1.38.0-wmf.1/index.php(46): wfIndexMain()
#10 /srv/mediawiki/w/index.php(3): require(string)
#11 {main}

Impact

Notes

Cause when someone goes to Special:Contributions/<some IP address>/24. I guess they are looking for contributions from a whole network. The exception should be caught and user error reported.

I am assuming the issue is MobileFrontend since the end of the trace has SpecialMobileContributions

Details

Request URL: https://ang.wikiquote.org/wiki/Syndrig:Contributions/x.x.x.x/22

	Subject	Repo	Branch	Lines +/-
	Add test for invalid IP address error	mediawiki/extensions/MobileFrontend	master	+25 -0
	Make sure an IP address is valid	mediawiki/extensions/MobileFrontend	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T292153: Fatal exception of type "InvalidArgumentException" when viewing some user contributions in the mobile version
T291233: [interrupt work/regression] MobileFrontend errors out when attempting to view contributions for IP editors
Mentioned Here: T241455: Special:History formatting issue in MessageBox
T291233: [interrupt work/regression] MobileFrontend errors out when attempting to view contributions for IP editors
rEMFR61ae6947b3b1: specials: Make SpecialContributions be able to view IP editors contribs

Event Timeline

hashar created this task.Sep 21 2021, 7:48 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 21 2021, 7:48 PM

hashar lowered the priority of this task from Unbreak Now! to Medium.Sep 21 2021, 7:50 PM

Probably caused by rEMFR61ae6947b3b1: specials: Make SpecialContributions be able to view IP editors contribs, T291233: [interrupt work/regression] MobileFrontend errors out when attempting to view contributions for IP editors.

Change 722673 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/MobileFrontend@master] Make sure an IP address is valid

https://gerrit.wikimedia.org/r/722673

gerritbot added a project: Patch-For-Review.Sep 21 2021, 8:08 PM

Zabe moved this task from Untriaged to Sep 2021 on the Wikimedia-production-error board.Sep 21 2021, 8:35 PM

Zabe mentioned this in T291233: [interrupt work/regression] MobileFrontend errors out when attempting to view contributions for IP editors.Sep 21 2021, 10:26 PM

Merging to address the fatal, but this also suffers from the same issue described in https://phabricator.wikimedia.org/T241455

Jdlrobson added a project: Web-Team-Backlog (Kanbanana-FY-2021-22).Sep 22 2021, 2:07 AM

Jdlrobson moved this task from Needs Analysis to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Change 722673 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Make sure an IP address is valid

https://gerrit.wikimedia.org/r/722673

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.2; 2021-09-28).Sep 22 2021, 3:00 AM

Maintenance_bot removed a project: Patch-For-Review.Sep 22 2021, 3:11 AM

LGoto assigned this task to cjming.Sep 22 2021, 4:43 PM

Titore subscribed.Sep 24 2021, 9:58 PM

Lucas_Werkmeister_WMDE mentioned this in T292153: Fatal exception of type "InvalidArgumentException" when viewing some user contributions in the mobile version.Sep 30 2021, 9:15 AM

RhinosF1 merged a task: T292153: Fatal exception of type "InvalidArgumentException" when viewing some user contributions in the mobile version.Sep 30 2021, 9:21 AM

RhinosF1 added subscribers: • IN, Ladsgroup, Lucas_Werkmeister_WMDE and 2 others.

Is there a reason not to backport the fix to wmf.1? Otherwise I suggest doing that in the upcoming backport+config window.

Change 724947 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/MobileFrontend@master] Add test for invalid IP address error

https://gerrit.wikimedia.org/r/724947

gerritbot added a project: Patch-For-Review.Sep 30 2021, 9:37 AM

hi @Jdlrobson - even though https://gerrit.wikimedia.org/r/722673 was merged on 9/21/21, I still see nearly 5k of these errors from the past week. Is it because this needs to be backported still?

In T291519#7392311, @cjming wrote:

hi @Jdlrobson - even though https://gerrit.wikimedia.org/r/722673 was merged on 9/21/21, I still see nearly 5k of these errors from the past week. Is it because this needs to be backported still?

The fix is part of wmf.2, which has not yet been deployed to all wikis.

In T291519#7392358, @Zabe wrote:

The fix is part of wmf.2, which has not yet been deployed to all wikis.

gtk - thanks for clarifying

wmf.2 has now been deployed to all wikis and https://en.m.wikipedia.org/wiki/Special:Contributions/101.99.60.0/19 no longer throws fatals. @Jdlrobson can you take a look at the tests by Lucas, thanks.

I'm sorry, only just saw this patch for the backport window. There was no reason why we couldn't have backported this.

I'll take ownership of getting your tests patch merged. I'm a bit behind on my my code review queue.

Change 724947 merged by jenkins-bot: