Page MenuHomePhabricator
Create Task
Maniphest T291675

Time on New Pages Feed is displayed in browser timezone instead of timezone set in preferences
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To
Legoktm
Authored By
Tol
Sep 24 2021, 12:11 AM
Tags
Referenced Files
None
Subscribers
Aklapper
DannyS712
Dreamy_Jazz
Krinkle
Legoktm
Nardog
SD0001
View All 10 Subscribers

Description

List of steps to reproduce (step by step, including full links if applicable):

What happens?:
Times are in browser time (usually the time of wherever you are). This is the case for both the date/time articles were created and the date/time creating users' accounts were created (the "edit count edits since date").

What should have happened instead?:
Times should be in the timezone you set in Special:Preferences#mw-prefsection-rendering. Preferably, without the extremely large timezone identifier, "GMT±XXXX (name of timezone)".

Details

SubjectRepoBranchLines +/-
Revert "Remove deprecated date.js library"mediawiki/extensions/PageTriagewmf/1.38.0-wmf.1+223 -49
Revert "Remove deprecated date.js library"mediawiki/extensions/PageTriagemaster+223 -49
Customize query in gerrit

Related Objects

Event Timeline

Tol created this task.Sep 24 2021, 12:11 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptSep 24 2021, 12:11 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Tol added a comment.Sep 24 2021, 12:14 AM

I'm pretty sure this is new; at least, I hadn't noticed this before. And it's gigantic; I would have noticed it.

DannyS712 added subscribers: SD0001, DannyS712.Sep 24 2021, 1:08 AM

Suspected cause rEPTR9772b49b41be: Remove deprecated date.js library / T268513: PageTriage's external Date.js modifies/overwrites native JavaScript Date prototype, should be updated - cc @SD0001

SD0001 added a subscriber: Krinkle.Sep 24 2021, 6:52 AM

Ohh. It appears PageTriage was also relying on Date.prototype.toString modified by date.js library (which takes a format string). So when the library was removed, we're now seeing the native browser toString() method which produces the ugly output. Looks like there's no way to fix this other than to bring back the deprecated library by reverting rEPTR9772b49b41be . cc @Krinkle

Nardog merged a task: T291685: NewPagesFeed is showing timestamps in extremely long format.Sep 24 2021, 11:20 AM
Nardog added subscribers: Xaosflux, Dreamy_Jazz.
Xaosflux added a project: Regression.Sep 24 2021, 11:22 AM
Nardog subscribed.Sep 24 2021, 11:35 AM

Didn't know client-side date formatting was implemented in such a localized way. About time T21992 (from 2009!) was made a reality.

Tamzin subscribed.Sep 24 2021, 5:05 PM
gerritbot added a comment.Sep 24 2021, 5:23 PM

Change 723581 had a related patch set uploaded (by Legoktm; author: Legoktm):

[mediawiki/extensions/PageTriage@master] Revert \"Remove deprecated date.js library\"

https://gerrit.wikimedia.org/r/723581

gerritbot added a project: Patch-For-Review.Sep 24 2021, 5:23 PM
Legoktm triaged this task as Unbreak Now! priority.Sep 24 2021, 5:33 PM
Nardog added a comment.Sep 24 2021, 5:43 PM

I suspect switching to moment.js is the obvious course of action in the medium term, although it makes sense to revert 9772b49b41be for now. In the long term, core should provide a way to convert a date to the format the user sees in history, contributions, etc. client-side (T21992).

gerritbot added a comment.Sep 24 2021, 6:02 PM

Change 723581 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Revert \"Remove deprecated date.js library\"

https://gerrit.wikimedia.org/r/723581

gerritbot added a comment.Sep 24 2021, 6:02 PM

Change 723583 had a related patch set uploaded (by Legoktm; author: Legoktm):

[mediawiki/extensions/PageTriage@wmf/1.38.0-wmf.1] Revert \"Remove deprecated date.js library\"

https://gerrit.wikimedia.org/r/723583

Tol added a subscriber: Legoktm.Sep 24 2021, 6:47 PM

@Legoktm, thanks for taking care of this!

gerritbot added a comment.Sep 24 2021, 6:51 PM

Change 723583 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@wmf/1.38.0-wmf.1] Revert \"Remove deprecated date.js library\"

https://gerrit.wikimedia.org/r/723583

Stashbot added a comment.Sep 24 2021, 6:54 PM

Mentioned in SAL (#wikimedia-operations) [2021-09-24T18:54:52Z] <legoktm@deploy1002> Synchronized php-1.38.0-wmf.1/extensions/PageTriage/: Revert "Remove deprecated date.js library" (T291675) (duration: 00m 59s)

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.2; 2021-09-28).Sep 24 2021, 7:00 PM
Legoktm closed this task as Resolved.Sep 24 2021, 7:06 PM
Legoktm claimed this task.

This should be fixed now.

Legoktm mentioned this in T268513: PageTriage's external Date.js modifies/overwrites native JavaScript Date prototype, should be updated.Sep 24 2021, 7:07 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 24 2021, 7:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits
  NODES
Note 3
Project 5
USERS 1