Page MenuHomePhabricator
Create Task
Maniphest T293924

Also run PHP 7.4 jobs on wmf branch patches
Closed, ResolvedPublic
Actions

Assigned To
Jdforrester-WMF
Authored By
Reedy
Oct 20 2021, 6:49 PM
Tags
Referenced Files
None
Subscribers
Aklapper
Daimona
hashar
ppelberg
Reedy

Details

SubjectRepoBranchLines +/-
Zuul: Enable PHP74 jobs on gate-and-submit-wmf pipeline [Re-re-try]integration/configmaster+24 -0
Zuul: Enable PHP74 jobs on gate-and-submit-wmf pipeline [Re-try]integration/configmaster+24 -0
Revert "Zuul: Enable PHP74 jobs on gate-and-submit-wmf pipeline"integration/configmaster+0 -24
phan: Upgrade mediawiki-phan-config to 0.11.1 and set minimum__target_php_versionmediawiki/coremaster+34 -19
Zuul: Enable PHP74 jobs on gate-and-submit-wmf pipelineintegration/configmaster+24 -0
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedNoneT248925 Make MediaWiki release tarball compatible with PHP 8.0
 ResolvedJdforrester-WMFT300463 Make PHP 8.0 voting on MW master
 ResolvedJdforrester-WMFT313563 Bump lcobucci/jwt & league/uri-components for php8
 ResolvedJdforrester-WMFT313564 Bump onoi/message-reporter in vendor.git to 1.4.2 for php 8 support
 ResolvedJdforrester-WMFT247658 Make Wikimedia Production MediaWiki compatible with PHP 7.4
 Resolved• toanT243590 Fix WikibaseDataModel CI for php 7.4
 ResolvedLucas_Werkmeister_WMDET316923 Restore skipped test in ReferenceListTest.php
 ResolvedJoeT318918 Undeploy patch to use old PHP serialization in PHP 7.4
 ResolvedJdforrester-WMFT264168 Drop PHP 7.2 support from Wikibase master branch, once Wikimedia production is on 7.4
 ResolvedLadsgroupT270740 Drop hacky support for doctrine/dbal class renaming
 InvalidNoneT303505 [S] Remove Deprecated methods "serialize" and "unserialize" after php production upgrade to PHP 7.4
 ResolvedReedyT251043 Cleanup css-sanitizer when it only requires PHP >= 7.4
 OpenNoneT166010 The Great Namespaceization Effort
 Resolved• tstarlingT277618 var_dump() on various objects writes gigabytes of data and takes minutes to run
 ResolvedJdforrester-WMFT261872 Drop PHP 7.2 & 7.3 support from MediaWiki master branch, once Wikimedia production is on 7.4
 ResolvedPRODUCTION ERRORLegoktmT293568 PHP Notice: Undefined offset in wikimedia/remex-html when rendering rest.php error page
 Resolved• tstarlingT297667 mysqli/mysqlnd memory leak
 ResolvedJoeT271736 Migrate WMF production from PHP 7.2 to PHP 7.4
 ResolvedJdforrester-WMFT293924 Also run PHP 7.4 jobs on wmf branch patches
 ResolvedJdforrester-WMFT293851 Re-build all CI images of PHP 7.4 from sury's package to Wikimedia's one, to assure us that it will work
 ResolvedLegoktmT293449 Package php 7.4 for wikimedia production
 ResolvedJdforrester-WMFT295285 Upgrade primary branch of all Wikimedia-deployed repos to a version of mediawiki-tools-phan including T270553
 ResolvedDaimonaT295286 Release mediawiki-tools-phan 0.11.1
 ResolvedDaimonaT270553 Should mediawiki/mediawiki-phan-config ship a _target php version to support running with newer php on the developer side?
 ResolvedJdforrester-WMFT314896 WikiEditor edit sampling code triggers 'PHP Deprecated: Invalid characters passed for attempted conversion, these have been ignored' on PHP7.4+

Event Timeline

Reedy created this task.Oct 20 2021, 6:49 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 20 2021, 6:49 PM
Reedy added a subtask: T293851: Re-build all CI images of PHP 7.4 from sury's package to Wikimedia's one, to assure us that it will work.Oct 20 2021, 6:49 PM
Reedy renamed this task from Run PHP 7.4 as well as PHP 7.2 on wmf branch patches to Also run PHP 7.4 jobs on wmf branch patches.Oct 20 2021, 6:53 PM
Jdforrester-WMF closed subtask T293851: Re-build all CI images of PHP 7.4 from sury's package to Wikimedia's one, to assure us that it will work as Resolved.Oct 25 2021, 8:13 PM
gerritbot added a comment.Oct 25 2021, 9:48 PM

Change 734416 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] Zuul: Enable PHP74 jobs on gate-and-submit-wmf pipeline

https://gerrit.wikimedia.org/r/734416

gerritbot added a project: Patch-For-Review.Oct 25 2021, 9:48 PM
gerritbot added a comment.Oct 26 2021, 4:58 AM

Change 734416 merged by jenkins-bot:

[integration/config@master] Zuul: Enable PHP74 jobs on gate-and-submit-wmf pipeline

https://gerrit.wikimedia.org/r/734416

Stashbot added a comment.Oct 26 2021, 4:59 AM

Mentioned in SAL (#wikimedia-releng) [2021-10-26T04:59:09Z] <James_F> Zuul: Enable PHP74 jobs on gate-and-submit-wmf pipeline T293924

Jdforrester-WMF closed this task as Resolved.Oct 26 2021, 5:02 AM
Jdforrester-WMF claimed this task.
Jdforrester-WMF mentioned this in T293947: 1.38.0-wmf.6 deployment blockers.
Maintenance_bot removed a project: Patch-For-Review.Oct 26 2021, 5:10 AM
gerritbot added a comment.Oct 26 2021, 8:22 AM

Change 734325 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[integration/config@master] Revert \"Zuul: Enable PHP74 jobs on gate-and-submit-wmf pipeline\"

https://gerrit.wikimedia.org/r/734325

gerritbot added a project: Patch-For-Review.Oct 26 2021, 8:22 AM
hashar reopened this task as Open.Oct 26 2021, 8:25 AM
hashar subscribed.

Reverted due to some issue with GrowthExperiments at least T293947#7457724

gerritbot added a comment.Oct 26 2021, 8:25 AM

Change 734325 merged by jenkins-bot:

[integration/config@master] Revert \"Zuul: Enable PHP74 jobs on gate-and-submit-wmf pipeline\"

https://gerrit.wikimedia.org/r/734325

Maintenance_bot removed a project: Patch-For-Review.Oct 26 2021, 9:10 AM
Daimona subscribed.Oct 26 2021, 9:24 AM
In T293924#7457729, @hashar wrote:

Reverted due to some issue with GrowthExperiments at least T293947#7457724

We cannot really switch phan job to PHP 7.4: phan uses the PHP version it's executed on in two ways:

  1. To infer accurate signatures via Reflection (not sure how much this would affect us)
  2. To determine the minimum PHP version supported by the codebase.

2 is what's causing the failure there: if we run phan with 7.4, it thinks that 7.4 is the minimum supported version, and suggests fixes that are only available in 7.4+. This behaviour can be changed, of course. In fact, the minimum supported version is determined by the first available value in the following list:

minimum__target_php_version phan option -> composer requirement for php -> _target_php_version phan option -> PHP version used to run phan

So we'd need to specify one (or more) of the first three.

Legoktm reopened subtask T293851: Re-build all CI images of PHP 7.4 from sury's package to Wikimedia's one, to assure us that it will work as Open.Nov 10 2021, 4:40 PM
gerritbot added a comment.Dec 20 2021, 12:26 PM

Change 748718 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] phan: Upgrade mediawiki-phan-config to 0.11.1 and set minimum__target_php_version

https://gerrit.wikimedia.org/r/748718

gerritbot added a project: Patch-For-Review.Dec 20 2021, 12:26 PM
gerritbot added a comment.Mar 29 2022, 5:17 PM

Change 748718 merged by jenkins-bot:

[mediawiki/core@master] phan: Upgrade mediawiki-phan-config to 0.11.1 and set minimum__target_php_version

https://gerrit.wikimedia.org/r/748718

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.6; 2022-04-04).Mar 29 2022, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 29 2022, 6:10 PM
Jdforrester-WMF closed subtask T295285: Upgrade primary branch of all Wikimedia-deployed repos to a version of mediawiki-tools-phan including T270553 as Resolved.Aug 3 2022, 12:21 PM
Jdforrester-WMF closed subtask T293851: Re-build all CI images of PHP 7.4 from sury's package to Wikimedia's one, to assure us that it will work as Resolved.Aug 9 2022, 8:53 PM
gerritbot added a comment.Aug 9 2022, 8:54 PM

Change 821729 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] Zuul: Enable PHP74 jobs on gate-and-submit-wmf pipeline [Re-try]

https://gerrit.wikimedia.org/r/821729

gerritbot added a project: Patch-For-Review.Aug 9 2022, 8:54 PM
gerritbot added a comment.Aug 9 2022, 9:06 PM

Change 821729 merged by jenkins-bot:

[integration/config@master] Zuul: Enable PHP74 jobs on gate-and-submit-wmf pipeline [Re-try]

https://gerrit.wikimedia.org/r/821729

Stashbot added a comment.Aug 9 2022, 9:07 PM

Mentioned in SAL (#wikimedia-releng) [2022-08-09T21:07:03Z] <James_F> Zuul: Enable PHP74 jobs on gate-and-submit-wmf pipeline [Re-try] for T293924

Maintenance_bot removed a project: Patch-For-Review.Aug 9 2022, 9:30 PM
ppelberg subscribed.Aug 9 2022, 9:53 PM
Jdforrester-WMF added a subtask: T314896: WikiEditor edit sampling code triggers 'PHP Deprecated: Invalid characters passed for attempted conversion, these have been ignored' on PHP7.4+ .Aug 9 2022, 9:54 PM
gerritbot added a comment.Aug 10 2022, 6:43 PM

Change 822146 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] Zuul: Enable PHP74 jobs on gate-and-submit-wmf pipeline [Re-re-try]

https://gerrit.wikimedia.org/r/822146

gerritbot added a project: Patch-For-Review.Aug 10 2022, 6:43 PM
gerritbot added a comment.Aug 29 2022, 12:05 PM

Change 822146 merged by jenkins-bot:

[integration/config@master] Zuul: Enable PHP74 jobs on gate-and-submit-wmf pipeline [Re-re-try]

https://gerrit.wikimedia.org/r/822146

Stashbot added a comment.Aug 29 2022, 12:08 PM

Mentioned in SAL (#wikimedia-releng) [2022-08-29T12:08:39Z] <James_F> Zuul: Enable PHP74 jobs on gate-and-submit-wmf pipeline [Re-re-try] for T293924

Jdforrester-WMF closed subtask T314896: WikiEditor edit sampling code triggers 'PHP Deprecated: Invalid characters passed for attempted conversion, these have been ignored' on PHP7.4+ as Resolved.Aug 29 2022, 12:13 PM
Jdforrester-WMF closed this task as Resolved.Aug 29 2022, 12:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits
  NODES
Note 3
Project 10