Page MenuHomePhabricator
Create Task
Maniphest T301034

Use language in variants link id instead of incrementing numbers
Closed, ResolvedPublicFeature
Actions

Assigned To
Jdlrobson
Authored By
Xiplus
Feb 5 2022, 7:03 AM
Tags
Referenced Files
F34957455: Screen Shot 2022-02-18 at 1.43.16 PM.png
Feb 18 2022, 9:43 PM
F34942882: Capture.JPG
Feb 5 2022, 7:03 AM
Subscribers
Aklapper
Jdlrobson
Xiplus

Description

Feature summary (what you would like to be able to do and where):

Capture.JPG (726×682 px, 99 KB)

Currently variant links id use incrementing numbers (#ca-varlang-0, #ca-varlang-1, etc.). I suggested use language name as id (#ca-varlang-zh-Hans, #ca-varlang-zh-Hant, etc.).

Benefits (why should this be implemented?):
It's easier to control individual link for JS or CSS. For example, hide specific language links.
https://zh.wikipedia.org/wiki/MediaWiki:Gadget-hideConversionTab.css

Details

SubjectRepoBranchLines +/-
Use language name in variants link idmediawiki/coremaster+1 -0
Customize query in gerrit

Event Timeline

Xiplus created this task.Feb 5 2022, 7:03 AM
Restricted Application added subscribers: Stang, Aklapper. · View Herald TranscriptFeb 5 2022, 7:03 AM
gerritbot added a comment.Feb 5 2022, 7:08 AM

Change 759851 had a related patch set uploaded (by A2093064; author: A2093064):

[mediawiki/core@master] Use language name in variants link id

https://gerrit.wikimedia.org/r/759851

gerritbot added a project: Patch-For-Review.Feb 5 2022, 7:08 AM
Xiplus added a comment.Feb 5 2022, 7:47 AM

It affects these extensions: https://codesearch.wmcloud.org/search/?q=%23ca-varlang
I think we can add a new class like .ca-variants and use .ca-variants:first to specify first link.

Jdlrobson moved this task from Backlog to Unused 3 on the MediaWiki-Core-Skin-Architecture board.Feb 7 2022, 11:25 PM
Jdlrobson moved this task from Unused 3 to Menus 2.0 on the MediaWiki-Core-Skin-Architecture board.Feb 10 2022, 4:21 PM
Jdlrobson edited projects, added MediaWiki-Core-Skin-Architecture (Menus 2.0); removed MediaWiki-Core-Skin-Architecture.
gerritbot added a comment.Feb 16 2022, 7:39 PM

Change 759851 merged by jenkins-bot:

[mediawiki/core@master] Use language name in variants link id

https://gerrit.wikimedia.org/r/759851

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.23; 2022-02-21).Feb 16 2022, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 16 2022, 8:10 PM
Jdlrobson moved this task from Backlog to Menu prep work on the MediaWiki-Core-Skin-Architecture (Menus 2.0) board.Feb 18 2022, 9:40 PM
Jdlrobson closed this task as Resolved.Feb 18 2022, 9:43 PM
Jdlrobson claimed this task.
Jdlrobson edited projects, added Patch-For-Review, Web-Team-Backlog (Kanbanana-FY-2021-22); removed MW-1.38-notes (1.38.0-wmf.23; 2022-02-21).
Jdlrobson subscribed.

Fixed in beta cluster (https://zh.wikipedia.beta.wmflabs.org/wiki/Albert_Einstein):

Screen Shot 2022-02-18 at 1.43.16 PM.png (1×1 px, 375 KB)

Stang removed a project: Patch-For-Review.Mar 13 2022, 3:31 PM
Stang unsubscribed.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits
  NODES
HOME 1
Note 3
os 3
web 2