Scrollbars are shown in language selector even when they aren't needed
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	BrandonXLF
	Feb 6 2022, 2:20 AM

Description

List of steps to reproduce

Make sure Vector (2022) is selected
Go a page only available in a few languages (https://en.wikipedia.org/wiki/Look_Through_Any_Window)
Click on the language dropdown

What happens?:
Scrollbars are present even though they aren't needed

What should have happened instead?:
Scrollbars should only be added when they are needed.

QA Steps

When the language list isn't scrollable

Using Windows 11 with Chrome 98, turn off javascript and visit https://en.wikipedia.beta.wmflabs.org/wiki/Language_test
Click the language button and ensure that a scrollbar isn't visible

Details

	Subject	Repo	Branch	Lines +/-
	Only show scrollbars when needed in language menu	mediawiki/skins/Vector	master	+1 -1

Customize query in gerrit

Event Timeline

BrandonXLF created this task.Feb 6 2022, 2:20 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 6 2022, 2:20 AM

Change 759998 had a related patch set uploaded (by BrandonXLF; author: BrandonXLF):

[mediawiki/skins/Vector@master] Only show scrollbars when needed in language menu

https://gerrit.wikimedia.org/r/759998

gerritbot added a project: Patch-For-Review.Feb 6 2022, 2:25 AM

@ovasileva there is a patch from a volunteer for this one. Should we move into the sprint board?

@BrandonXLF what operating system and browser are you on? also to note, from the screenshot it looks like this is the non-JS version of the ULS

In T301058#7693466, @alexhollender_WMF wrote:

@BrandonXLF what operating system and browser are you on? also to note, from the screenshot it looks like this is the non-JS version of the ULS

I'm on Windows 11 with Chrome 98. I have JavaScript enabled so I'm not sure why I would be seeing the non JS version.

In T301058#7693731, @BrandonXLF wrote:

In T301058#7693466, @alexhollender_WMF wrote:

@BrandonXLF what operating system and browser are you on? also to note, from the screenshot it looks like this is the non-JS version of the ULS

I'm on Windows 11 with Chrome 98. I have JavaScript enabled so I'm not sure why I would be seeing the non JS version.

You will see the no-Js version with this setting unchecked:

https://en.wikipedia.org/wiki/Special:Preferences#mw-prefsection-rendering

We don't really officially support this fallback preference so I am not surprised it doesn't look great.

Jdlrobson moved this task from Incoming to Language Switching on the Desktop Improvements (Vector 2022) board.Feb 8 2022, 5:21 PM

Jdlrobson moved this task from Incoming to Not ready to estimate on the Web-Team-Backlog board.Feb 9 2022, 11:41 PM

There is a patch to review from a volunteer.

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Feb 21 2022, 8:46 PM

ovasileva triaged this task as Low priority.Feb 28 2022, 6:29 PM

Change 759998 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Only show scrollbars when needed in language menu

https://gerrit.wikimedia.org/r/759998

• nray updated the task description. (Show Details)Mar 1 2022, 8:25 PM

• nray updated the task description. (Show Details)

I went ahead and +2'd the patch given that the change was small, and it had been lingering for some time. The changes on beta look good to me so I'm assuming this can be moved to sign off (of course please correct if it should be to another column!):

• nray moved this task from Upcoming to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Mar 1 2022, 8:51 PM

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.25; 2022-03-07).Mar 1 2022, 9:00 PM

Maintenance_bot removed a project: Patch-For-Review.Mar 1 2022, 9:10 PM

lgtm - tested

cjming reassigned this task from cjming to BrandonXLF.Mar 2 2022, 7:19 PM

cjming subscribed.

	F34945722: Screen Shot 2022-02-08 at 9.19.46 AM.png
	Feb 8 2022, 5:20 PM

	F34971556: without-scroll.png
	Mar 1 2022, 8:51 PM