Page MenuHomePhabricator

Decommission the ExternalGuidance instrument
Closed, ResolvedPublic

Description

The decision to decommission the ExternalGuidance instrument was made in T283551: Decide whether to keep the ExternalGuidance data stream. This task tracks the follow-up work to decommission it.

TODO

  • Remove all instances of code like:
mw.track( 'event.ExternalGuidance', { /* ... */ } );

Notes

  1. AFAICT the ExternalGuidance extension does not use mw.logEvent directly (see https://codesearch.wmcloud.org/search/?q=logEvent&repos=Extension:ExternalGuidance)

Event Timeline

Remove the ExternalGuidance event sanitisation allowlist entry

Should the entry be removed? I wasn't sure if removing it would have an effect on already-sanitised data.

Remove the ExternalGuidance event sanitisation allowlist entry

Should the entry be removed? I wasn't sure if removing it would have an effect on already-sanitised data.

Per https://wikitech.wikimedia.org/wiki/Analytics/Systems/EventLogging#Retiring_a_schema, yes.

Change 769933 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/extensions/ExternalGuidance@master] Remove the ExternalGuidance instrument

https://gerrit.wikimedia.org/r/769933

Change 769937 had a related patch set uploaded (by Phuedx; author: Phuedx):

[analytics/refinery@master] Remove ExternalGuidance from allow list

https://gerrit.wikimedia.org/r/769937

Change 769937 merged by Mforns:

[analytics/refinery@master] Remove ExternalGuidance from allow list

https://gerrit.wikimedia.org/r/769937

Change 769933 merged by jenkins-bot:

[mediawiki/extensions/ExternalGuidance@master] Remove the ExternalGuidance instrument

https://gerrit.wikimedia.org/r/769933

Request the deletion of any previously allowlisted data if it's necessary

@nshahquinn-wmf: Are you using the data in the event_sanitized.externalguidance table? If so, then I'll resolve this task; otherwise, I'll request that the data is deleted.

@phuedx no, you can go ahead and delete that data. Thanks for taking care of this! 😊

phuedx claimed this task.
phuedx updated the task description. (Show Details)

Being bold.

  NODES
Note 4
Project 5
todo 1