Page MenuHomePhabricator

Sitelinks dropping down to the bottom of page in Wikidata Vector 2022
Closed, ResolvedPublicBUG REPORT

Description

A previous attempt to fix this was in T300182 but it seems like this is now a Wikidata issue that perhaps can be solved by using skinStyles?

Steps to replicate the issue (include links if applicable):

What happens?:

Screen Shot 2022-08-31 at 10.37.55 AM.png (1×2 px, 273 KB)

What should have happened instead?:

image.png (1×2 px, 333 KB)

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

Olga: possible blocker for wikidata so we might want to reach out to WMDE to get this prioritized.

ovasileva triaged this task as Medium priority.Sep 12 2022, 10:29 AM

If I remove Vector 2022’s limitations on the page container’s width in dev tools, then the sitelinks move to the side again:

image.png (765×797 px, 72 KB)

(Edit: In the screenshot, I disabled the padding as well as the max-width, but it turns out disabling the max-width is enough on its own, you can leave the padding as it is.)

Is the restriction on the page width relevant for Wikidata? I thought it was aimed at large amounts of prose, like Wikipedia articles. Could it just be turned off by default?

If I remove Vector 2022’s limitations on the page container’s width in dev tools, then the sitelinks move to the side again.

image.png (765×797 px, 72 KB)

Unfortunately, simply removing the max-width of .mw-page-container would cause the content of entity pages to overflow their margins, and make them become excessively wide. Further adjustments would be needed. Here's a screenshot with an exaggerated width (>1800px) so the effect is easier to perceive:

Screenshot 2024-06-25 at 13.01.53.png (1×2 px, 326 KB)

I would try to find a more localized and scalable solution, probably related to adjusting min-widths and breakpoints. I'm currently working on a design proposal: it'd be great to get help to validate its feasibility 🙏🏻

Lydia_Pintscher renamed this task from Languages show at bottom of page in Wikidata Vector 2022 skin due to media query that should be reconsidered to Language links show at bottom of page in Wikidata Vector 2022 skin due to media query that should be reconsidered.Sep 24 2024, 12:16 PM
Arian_Bozorg renamed this task from Language links show at bottom of page in Wikidata Vector 2022 skin due to media query that should be reconsidered to Sitelinks dropping down to the bottom of page in Wikidata Vector 2022.Sep 24 2024, 2:37 PM
Arian_Bozorg claimed this task.
Arian_Bozorg subscribed.

This seems to be fixed now

image.png (967×1 px, 249 KB)

This seems to be fixed now

image.png (967×1 px, 249 KB)

Still visible here. Try narrowing your screen a bit more, e.g., until 'View history' is above the sitelink box?

Hi Mike, can you give me some details of the browser and the width of the screen?

Hi Mike, can you give me some details of the browser and the width of the screen?

Firefox on Mac, latest versions. For the width, see the task description - 'Make sure screen is < 1570px'.

  NODES
HOME 1
languages 1
mac 1
Note 1
os 9
web 5