Page MenuHomePhabricator
Create Task
Maniphest T316865

AddImage: Clicking back does not take user back to Special:Homepage
Open, Stalled, LowPublicBUG REPORT
Actions

Assigned To
None
Authored By
kostajh
Sep 1 2022, 11:22 AM
Tags
Referenced Files
None
Subscribers
Aklapper
Etonkovidova
• KMorgan-WMF
kostajh
KStoller-WMF
Sgs

Description

Steps to replicate the issue (include links if applicable):

  • Go to Special:Homepage
  • Click on an image recommendation task
  • Click back in the browser

What happens?:

The URL changes from:

On mobile, there is a different issue: swiping back takes you to the read view of the page, but I would expect it to take me to Special:Homepage.
Tested on eswiki wmf.30 - the issue is not present.
What should have happened instead?:

I should be back at Special:Homepage

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Related Objects
Search...

Event Timeline

kostajh created this task.Sep 1 2022, 11:22 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 1 2022, 11:22 AM
kostajh updated the task description. (Show Details)Sep 1 2022, 11:24 AM
kostajh moved this task from Inbox to Needs Discussion on the Growth-Team board.

@KStoller-WMF please let us know how you'd like us to prioritize this bug. It seems like a relatively small task to take care of.

KStoller-WMF added a parent task: T315732: [EPIC] Structured Tasks: Patroller Focus.Sep 1 2022, 9:47 PM
KStoller-WMF edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Sep 1 2022, 9:51 PM

This seems like an important bug to fix, and if it's low-effort we should likely work on it soon.

I'm not sure if this quite fits within T315732, but really anything that makes Structured Tasks work better should lead to them being more appreciated by patrollers and more advanced users.

KStoller-WMF triaged this task as Low priority.Nov 3 2022, 9:00 PM
KStoller-WMF moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.
KStoller-WMF edited parent tasks, added: T293711: [EPIC] "Add an image" Iteration 2; removed: T315732: [EPIC] Structured Tasks: Patroller Focus.Nov 7 2022, 10:57 PM
DMburugu added a parent task: T311850: [Epic] FY 2022-23 Growth Maintenance Work.Jan 12 2023, 10:14 AM
DMburugu moved this task from Sprint 0 (Growth Team) to Triaged on the Growth-Team board.
DMburugu edited projects, added Growth-Team; removed Growth-Team (Sprint 0 (Growth Team)).
Sgs subscribed.Mar 30 2023, 3:43 PM
• KMorgan-WMF claimed this task.Mar 31 2023, 3:45 PM
KStoller-WMF edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.May 9 2023, 11:33 PM
KStoller-WMF moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
• KMorgan-WMF changed the task status from Open to Stalled.May 16 2023, 12:56 PM

@Sgs and I spent 8 hours+ combined debugging this and although we are able to replicate it, the amount of time we've sunk without finding a fix is too high for the priority of the task. Will have to revisit later.

• KMorgan-WMF removed • KMorgan-WMF as the assignee of this task.May 23 2023, 1:07 PM
• KMorgan-WMF subscribed.
KStoller-WMF moved this task from In Progress to Blocked / Needs work on the Growth-Team (Sprint 0 (Growth Team)) board.May 23 2023, 6:19 PM
DMburugu edited parent tasks, added: T340453: [Epic] FY 2023-24 Growth Maintenance Work; removed: T311850: [Epic] FY 2022-23 Growth Maintenance Work.Jun 26 2023, 4:47 PM
KStoller-WMF moved this task from Sprint 0 (Growth Team) to Backlog on the Growth-Team board.Oct 11 2023, 9:42 PM
KStoller-WMF edited projects, added Growth-Team; removed Growth-Team (Sprint 0 (Growth Team)).
Etonkovidova updated the task description. (Show Details)Oct 17 2023, 8:42 PM
Etonkovidova added a comment.Oct 17 2023, 9:10 PM

Testing notes: re-tested on eswiki wmf.30; checked

  • Add an article image and Add an image to an article section tasks
  • FF and Chrome browsers
  • the issue is present for Add link structured task - a user clicks on Skip all control, after that the browser Back button doesn't work as expected.
  • confirmed: when url changes &gesuggestededit=1&veaction=edit&section=all, a user will not be redirected back to Homepage.

    The table presents the test results:
Action - a user ...Result
clicked Back when a suggested article loaded (the intro tour is not shown; was dismissed by a user previously) a user goes back to Special:Homepage
clicked Back when the intro tour is displayed a user goes back to Special:Homepage
clicked Back during second, third, or fourth step of the intro tour no action, a user stays on the page; additional click on the Back is required to go back to Special:Homepage
clicked Back when a user clicked on Skip all no action, a user stays on the page; additional click on the Back is required to go back to Special:Homepage
clicked Back when a user finished the intro tour a user goes back to Special:Homepage
DMburugu edited parent tasks, added: T367429: [Epic] FY 2024-25 Growth Maintenance Work; removed: T340453: [Epic] FY 2023-24 Growth Maintenance Work.Jun 18 2024, 12:37 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits
  NODES
Note 2
Project 4
USERS 1