Red links marked as uneditable in visual editor
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matmarex
	Dec 2 2022, 5:51 PM

Description

Red links already existing in the article are marked as uneditable in visual editor. Likely caused by the recent red link changes in Parsoid.

Example: https://pl.wikipedia.org/w/index.php?title=JimJam&veaction=edit&section=6#Seriale_fabularne

Details

Subject	Repo	Branch	Lines +/-
Add more test cases for mw.libs.ve.get_targetDataFromHref	mediawiki/extensions/VisualEditor	master	+110 -6
Suppress redlinks	mediawiki/services/parsoid	master	+23 -40
Adjust to changes to redlink behavior from parsoid	mediawiki/extensions/VisualEditor	wmf/1.40.0-wmf.12	+16 -3
Adjust to changes to redlink behavior from parsoid	mediawiki/extensions/VisualEditor	master	+16 -3

Customize query in gerrit

Related Objects

Mentioned In: T327779: VisualEditor adds link= attribute to file transclusion if lang= parameter is set
T325566: VisualEditor percent-encodes all single quote in red link _target fragments, producing dirty diff
Mentioned Here: T324028: Incorrect page parsing in DiscussionTools due to red links in Parsoid HTML – can't reply, bad permalinks

Event Timeline

matmarex created this task.Dec 2 2022, 5:51 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 2 2022, 5:51 PM

Titore subscribed.Dec 2 2022, 9:09 PM

Sakretsu subscribed.Dec 2 2022, 9:58 PM

Sakretsu added a project: Regression.Dec 3 2022, 12:20 PM

Purge a page, open the visual editor and you'll see that it is now impossible to edit any red link. This task should be of high priority.

A09 subscribed.Dec 3 2022, 5:15 PM

GoingBatty subscribed.Dec 3 2022, 9:59 PM

Same issue on the English Wikipedia e.g., https://en.wikipedia.org/wiki/Anna_Hruby :-(

But not on https://en.wikipedia.org/wiki/Donald_Rosenfeld (which doesn't have any tables)

DLynch subscribed.Dec 5 2022, 12:24 AM

Change 864732 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/services/parsoid@master] Suppress redlinks

https://gerrit.wikimedia.org/r/864732

gerritbot added a project: Patch-For-Review.Dec 5 2022, 11:24 AM

ihurbain subscribed.Dec 5 2022, 11:25 AM

Test wiki created on Patch demo by IHurbainPalatin (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/e258f7c8ba/w

Let's see... the difference in markup is:

Old	`<a rel="mw:WikiLink" href="./I_am" title="I am" class="new" data-parsoid='{"stx":"simple","a":{"href":"./I_am"},"sa":{"href":"I am"},"dsr":[0,8,2,2]}'>I am</a>`
New	`<a rel="mw:WikiLink" href="./I_am?action=edit&redlink=1" title="I am" class="new" typeof="mw:LocalizedAttrs" data-parsoid='{"stx":"simple","a":{"href":"./I_am"},"sa":{"href":"I am"},"dsr":[0,8,2,2]}' data-mw-i18n='{"title":{"lang":"x-page","key":"red-link-title","params":["I am"]}}'>I am</a>`

So I'd assume that the typeof="ms:LocalizedAttrs" is the issue. VE doesn't know anything about it, and internal link nodes aren't allowed to have unknown types.

mw:LocalizedAttrs should be safe to edit for now. Ideally, any attribute marked as "this is a localized attribute" would be uneditable, but this is probably irrelevant for wikilink titles.

Note that https://www.mediawiki.org/wiki/Specs/HTML/2.6.0#Internationalization also defines mw:I18n as a new typeof - we probably will want to keep those uneditable.

Change 864794 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] Adjust to changes to redlink behavior from parsoid

https://gerrit.wikimedia.org/r/864794

Just to note, this is a similar cause to T324028.

DLynch edited projects, added Editing-team (Kanban Board); removed Editing-team.Dec 5 2022, 5:51 PM

DLynch moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.

Change 864794 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Adjust to changes to redlink behavior from parsoid

https://gerrit.wikimedia.org/r/864794

Change 864724 had a related patch set uploaded (by Bartosz Dziewoński; author: DLynch):

[mediawiki/extensions/VisualEditor@wmf/1.40.0-wmf.12] Adjust to changes to redlink behavior from parsoid

https://gerrit.wikimedia.org/r/864724

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.13; 2022-12-05).Dec 5 2022, 9:00 PM

Change 864724 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.40.0-wmf.12] Adjust to changes to redlink behavior from parsoid

https://gerrit.wikimedia.org/r/864724

Mentioned in SAL (#wikimedia-operations) [2022-12-05T21:22:26Z] <samtar@deploy1002> Started scap: Backport for [[gerrit:864724|Adjust to changes to redlink behavior from parsoid (T324352)]]

Mentioned in SAL (#wikimedia-operations) [2022-12-05T21:24:07Z] <samtar@deploy1002> samtar and matmarex: Backport for [[gerrit:864724|Adjust to changes to redlink behavior from parsoid (T324352)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet

Mentioned in SAL (#wikimedia-operations) [2022-12-05T21:31:32Z] <samtar@deploy1002> Finished scap: Backport for [[gerrit:864724|Adjust to changes to redlink behavior from parsoid (T324352)]] (duration: 09m 05s)

Looks fixed to me.

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.12; 2022-11-28); removed MW-1.40-notes (1.40.0-wmf.13; 2022-12-05).Dec 5 2022, 10:00 PM

In T324352#8444755, @matmarex wrote:

Looks fixed to me.

Confirmed with https://en.wikipedia.org/wiki/Anna_Hruby - thanks!

EAkinloose edited projects, added Verified; removed Editing QA.Dec 6 2022, 5:48 PM

EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.

Change 864732 abandoned by Subramanya Sastry:

[mediawiki/services/parsoid@master] Suppress redlinks

Reason:

Not needed anymore. Can always restore it if required for any reason.

https://gerrit.wikimedia.org/r/864732

GoingBatty unsubscribed.Dec 10 2022, 1:15 AM

Change 868190 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Add more test cases for mw.libs.ve.get_targetDataFromHref

https://gerrit.wikimedia.org/r/868190

gerritbot added a project: Patch-For-Review.Dec 14 2022, 10:58 PM

VPuffetMichel moved this task from To Triage to Triaged on the VisualEditor board.Dec 15 2022, 4:56 PM

matmarex mentioned this in T325566: VisualEditor percent-encodes all single quote in red link _target fragments, producing dirty diff.Dec 19 2022, 6:02 PM

ppelberg closed this task as Resolved.Dec 22 2022, 1:21 AM

Change 868190 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Add more test cases for mw.libs.ve.get_targetDataFromHref

https://gerrit.wikimedia.org/r/868190

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.18; 2023-01-09); removed MW-1.40-notes (1.40.0-wmf.12; 2022-11-28).Jan 9 2023, 7:00 PM

matmarex mentioned this in T327779: VisualEditor adds link= attribute to file transclusion if lang= parameter is set.Jan 24 2023, 1:42 PM

Test wiki on Patch demo by IHurbainPalatin (WMF) using patch(es) linked to this task was deleted:

~~https://patchdemo.wmflabs.org/wikis/e258f7c8ba/w/~~

Red links marked as uneditable in visual editorClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Red links marked as uneditable in visual editor
Closed, ResolvedPublic
Actions