PHP Deprecated: strtolower(): Passing null is deprecated (FlowAction.php)
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Krinkle
	Jan 11 2023, 8:25 PM

Description

Error

PHP Deprecated: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated
#0 [internal function]: MWExceptionHandler::handleError()
#1 /var/www/html/w/extensions/Flow/includes/Actions/FlowAction.php(129): strtolower()
#2 /var/www/html/w/extensions/Flow/includes/Actions/FlowAction.php(85): Flow\Actions\FlowAction->getRedirectUrl()
#3 /var/www/html/w/extensions/Flow/includes/Actions/ViewAction.php(26): Flow\Actions\FlowAction->showForAction()
#4 /var/www/html/w/extensions/Flow/includes/Actions/FlowAction.php(49): Flow\Actions\ViewAction->showForAction()
#5 /var/www/html/w/includes/MediaWiki.php(551): Flow\Actions\FlowAction->show()
#6 /var/www/html/w/includes/MediaWiki.php(328): MediaWiki->performAction()
#7 /var/www/html/w/includes/MediaWiki.php(916): MediaWiki->performRequest()
#8 /var/www/html/w/includes/MediaWiki.php(571): MediaWiki->main()

Steps

Install Flow (incl. Echo dependency) on plain MediaWiki (mediawiki-docker-dev).
Enable using $wgNamespaceContentModels[NS_USER_TALK] = 'flow-board';
Visit any User_talk page.

The above error is emitted unconditionally.

Other info

Deprecated since PHP 8.1. https://3v4l.org/X0WM5

Details

Subject	Repo	Branch	Lines +/-
Actions: Fix warning due to passing null to strtolower	mediawiki/extensions/Flow	REL1_38	+2 -1
Actions: Fix warning due to passing null to strtolower	mediawiki/extensions/Flow	REL1_39	+2 -1
Actions: Fix warning due to passing null to strtolower	mediawiki/extensions/Flow	master	+2 -1

Customize query in gerrit

Event Timeline

Krinkle created this task.Jan 11 2023, 8:25 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 11 2023, 8:25 PM

Change 879127 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/extensions/Flow@master] Actions: Fix warning due to passing null to strtolower

https://gerrit.wikimedia.org/r/879127

gerritbot added a project: Patch-For-Review.Jan 11 2023, 8:27 PM

Change 879127 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Actions: Fix warning due to passing null to strtolower

https://gerrit.wikimedia.org/r/879127

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.19; 2023-01-16).Jan 12 2023, 7:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 12 2023, 7:30 PM

Reedy closed this task as Resolved.Jan 12 2023, 7:32 PM

Reedy claimed this task.

Reedy moved this task from Backlog to Wikimedia production on the PHP 8.1 support board.

Change 879573 had a related patch set uploaded (by Reedy; author: Krinkle):

[mediawiki/extensions/Flow@REL1_39] Actions: Fix warning due to passing null to strtolower

https://gerrit.wikimedia.org/r/879573

gerritbot added a project: Patch-For-Review.Jan 12 2023, 7:32 PM

Reedy reassigned this task from Reedy to Krinkle.Jan 12 2023, 7:33 PM

Reedy subscribed.

Change 879574 had a related patch set uploaded (by Reedy; author: Krinkle):

[mediawiki/extensions/Flow@REL1_38] Actions: Fix warning due to passing null to strtolower

https://gerrit.wikimedia.org/r/879574

Change 879573 merged by jenkins-bot: