Page MenuHomePhabricator
Create Task
Maniphest T349197

[infra] Remove TTLAfterFinished from config before upgrade to 1.25
Closed, ResolvedPublic
Actions

Assigned To
aborrero
Authored By
taavi
Oct 18 2023, 11:21 AM
Tags
Referenced Files
None
Subscribers
aborrero
Aklapper
taavi

Description

W1018 11:20:11.121896       1 feature_gate.go:237] Setting GA feature gate TTLAfterFinished=true. It will be removed in a future release.

This needs to be removed from both the Puppet-provisioned bootstrap file and the live config on all clusters and control nodes.

It seems they remove it in 1.25:
https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.25.md#other-cleanup-or-flake-4
https://github.com/kubernetes/kubernetes/pull/109435/files#diff-71e3b98f9a6bbf5b8421e26a7ba0c079f397cd8d49abacdad943c66a4f44f03dL216

Related Objects
Search...

Event Timeline

taavi created this task.Oct 18 2023, 11:21 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 18 2023, 11:21 AM
taavi moved this task from Inbox to Epics on the cloud-services-team board.Oct 18 2023, 1:31 PM
taavi moved this task from Backlog to Ready to be worked on on the Toolforge board.Jan 16 2024, 4:32 PM
dcaro renamed this task from Remove TTLAfterFinished from config to [k8s] Remove TTLAfterFinished from config before upgrade to 1.25.Jan 24 2024, 2:22 PM
dcaro triaged this task as Medium priority.
dcaro updated the task description. (Show Details)
dcaro moved this task from Ready to be worked on to Workspace for triaging whenever needed on the Toolforge board.
taavi added a parent task: T316107: [infra,k8s] Upgrade Toolforge Kubernetes to version 1.25.Jan 24 2024, 2:24 PM
dcaro moved this task from Workspace for triaging whenever needed to Ready to be worked on on the Toolforge board.Feb 21 2024, 4:03 PM
dcaro renamed this task from [k8s] Remove TTLAfterFinished from config before upgrade to 1.25 to [infra] Remove TTLAfterFinished from config before upgrade to 1.25.Mar 5 2024, 5:16 PM
taavi updated the task description. (Show Details)Mar 18 2024, 1:37 PM
CodeReviewBot added a project: Patch-For-Review.Jul 2 2024, 11:07 AM

aborrero opened https://gitlab.wikimedia.org/repos/cloud/toolforge/lima-kilo/-/merge_requests/154

kind: drop TTLAfterFinished feature gate flag

aborrero changed the task status from Open to In Progress.Jul 2 2024, 11:40 AM
aborrero claimed this task.
aborrero added a project: User-aborrero.
aborrero moved this task from Backlog to Doing on the User-aborrero board.
aborrero subscribed.
Stashbot added a comment.Jul 2 2024, 11:51 AM

Mentioned in SAL (#wikimedia-cloud) [2024-07-02T11:51:36Z] <arturo> remove --feature-gates=TTLAfterFinished=true from kube-controller-manager static pod definition (T349197)

Stashbot added a comment.Jul 2 2024, 11:53 AM

Mentioned in SAL (#wikimedia-cloud) [2024-07-02T11:53:43Z] <arturo> cleanup kubeadm configmap from TTLAfterFinished settings (T349197)

aborrero added a comment.Jul 2 2024, 11:56 AM

removed from ops puppet in commit: https://gerrit.wikimedia.org/r/c/operations/puppet/+/791368

CodeReviewBot added a comment.Jul 2 2024, 11:56 AM

aborrero merged https://gitlab.wikimedia.org/repos/cloud/toolforge/lima-kilo/-/merge_requests/154

kind: drop TTLAfterFinished feature gate flag

aborrero closed this task as Resolved.Jul 2 2024, 11:56 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits
  NODES
Note 1
Project 2