Error in HelpPanel workflow: Cannot read properties of null (reading 'context') in AddImageMobileArticle_target
Open, MediumPublic4 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Jdlrobson
	Oct 27 2023, 5:50 PM

Description

Error was present in wmf30 but increased by a large magnitude in wmf.1 to close to UBN levels (6880 errors in last 7 days - presumably relating to a deploy?). Please note it is getting close to a rate we would consider blocking the train for so should likely be fixed before any further roll outs. https://wikitech.wikimedia.org/wiki/Deployments/Holding_the_train#Error-rate_increases_(See_#Logspam).

e.g. https://logstash.wikimedia.org/app/dashboards#/doc/logstash-*/logstash-default-1-7.0.0-1-2023.10.27?id=0WU8cosBhro2teuGReau

The error appears in various forms, but all stack traces point to GrowthExperiments Help panel.

	at eval  https://en.m.wikipedia.org/w/load.php?lang=en&modules=ext.growthExperiments.HelpPanel&skin=minerva&version=nodc4:4:962
at Object.fire  https://en.m.wikipedia.org/w/load.php?lang=en&modules=mediawiki.base&skin=minerva&version=nrkdt:4:699
at ve.init.mw.Article_target.surfaceReady  https://en.m.wikipedia.org/w/load.php?lang=en&modules=ext.visualEditor.article_target%2Cbase%2Ccore%2Cdiffing%2CeditCheck%2Cicons%2Clanguage%2Cmediawiki%2CmobileArticle_target%2Cmwalienextension%2Cmwcore%2Cmwextensions%2Cmwformatting%2Cmwgallery%2Cmwimage%2Cmwlanguage%2Cmwlink%2Cmwmeta%2Cmwsave%2Cmwsignature%2Cmwtransclusion%2Csanitize%2CsupportCheck%2Cswitching%2Cwelcome%7Cext.visualEditor.core.mobile%2Cutils%7Cext.visualEditor.mwimage.core&skin=minerva&version=1ssd6:10:461
at ve.init.mw.MobileArticle_target.surfaceReady  https://en.m.wikipedia.org/w/load.php?lang=en&modules=ext.visualEditor.article_target%2Cbase%2Ccore%2Cdiffing%2CeditCheck%2Cicons%2Clanguage%2Cmediawiki%2CmobileArticle_target%2Cmwalienextension%2Cmwcore%2Cmwextensions%2Cmwformatting%2Cmwgallery%2Cmwimage%2Cmwlanguage%2Cmwlink%2Cmwmeta%2Cmwsave%2Cmwsignature%2Cmwtransclusion%2Csanitize%2CsupportCheck%2Cswitching%2Cwelcome%7Cext.visualEditor.core.mobile%2Cutils%7Cext.visualEditor.mwimage.core&skin=minerva&version=1ssd6:1271:894
at https://en.m.wikipedia.org/w/load.php?lang=en&modules=ext.visualEditor.article_target%2Cbase%2Ccore%2Cdiffing%2CeditCheck%2Cicons%2Clanguage%2Cmediawiki%2CmobileArticle_target%2Cmwalienextension%2Cmwcore%2Cmwextensions%2Cmwformatting%2Cmwgallery%2Cmwimage%2Cmwlanguage%2Cmwlink%2Cmwmeta%2Cmwsave%2Cmwsignature%2Cmwtransclusion%2Csanitize%2CsupportCheck%2Cswitching%2Cwelcome%7Cext.visualEditor.core.mobile%2Cutils%7Cext.visualEditor.mwimage.core&skin=minerva&version=1ssd6:1261:181

Alternative stack trace (at lower rate):

at onContextResize  https://th.m.wikipedia.org/w/load.php?lang=th&modules=ext.growthExperiments.HelpPanel&skin=minerva&version=1r78k:4:738
at later  https://th.m.wikipedia.org/w/load.php?lang=th&modules=oojs-ui-core%2Coojs-ui-widgets&skin=minerva&version=gt6lb:3:152

And

at eval  https://fa.m.wikipedia.org/w/load.php?lang=fa&modules=ext.growthExperiments.HelpPanel&skin=minerva&version=axojv:4:962
at Object.fire  https://fa.m.wikipedia.org/w/load.php?lang=fa&modules=mediawiki.base&skin=minerva&version=1uehh:4:699
at AddLinkMobileArticle_target.ve.init.mw.Article_target.surfaceReady  https://fa.m.wikipedia.org/w/load.php?lang=fa&modules=ext.visualEditor.article_target&skin=minerva&version=o94fy:10:461
at AddLinkMobileArticle_target.ve.init.mw.MobileArticle_target.surfaceReady  https://fa.m.wikipedia.org/w/load.php?lang=fa&modules=ext.visualEditor.mobileArticle_target&skin=minerva&version=1h30k:5:894
at AddLinkMobileArticle_target.StructuredTaskArticle_target.surfaceReady  https://fa.m.wikipedia.org/w/load.php?lang=fa&modules=ext.growthExperiments.StructuredTask&skin=minerva&version=gu6aw:25:363
at eval  https://fa.m.wikipedia.org/w/load.php?lang=fa&modules=ext.visualEditor.mediawiki&skin=minerva&version=omya8:24:181

and

at eval  https://fa.m.wikipedia.org/w/load.php?lang=fa&modules=ext.growthExperiments.HelpPanel&skin=minerva&version=axojv:4:962
at Object.fire  https://fa.m.wikipedia.org/w/load.php?lang=fa&modules=mediawiki.base&skin=minerva&version=1uehh:4:699
at AddImageMobileArticle_target.ve.init.mw.Article_target.surfaceReady  https://fa.m.wikipedia.org/w/load.php?lang=fa&modules=ext.visualEditor.article_target&skin=minerva&version=o94fy:10:461
at AddImageMobileArticle_target.ve.init.mw.MobileArticle_target.surfaceReady  https://fa.m.wikipedia.org/w/load.php?lang=fa&modules=ext.visualEditor.mobileArticle_target&skin=minerva&version=1h30k:5:894
at AddImageMobileArticle_target.StructuredTaskArticle_target.surfaceReady  https://fa.m.wikipedia.org/w/load.php?lang=fa&modules=ext.growthExperiments.StructuredTask&skin=minerva&version=gu6aw:25:363
at eval  https://fa.m.wikipedia.org/w/load.php?lang=fa&modules=ext.visualEditor.mediawiki&skin=minerva&version=omya8:24:181

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		None	T340453 [Epic] FY 2023-24 Growth Maintenance Work
Open		None	T325082 Eslint: configure browser compatibility
Open		None	T367429 [Epic] FY 2024-25 Growth Maintenance Work
Open	BUG REPORT	Sgs	T349933 Error in HelpPanel workflow: Cannot read properties of null (reading 'context') in AddImageMobileArticle_target

Event Timeline

Jdlrobson created this task.Oct 27 2023, 5:50 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptOct 27 2023, 5:50 PM

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald Transcript

Jdlrobson updated the task description. (Show Details)Oct 27 2023, 5:50 PM

Checked few different errors related to ext.growthExperiments.HelpPanel - logstash link.

TypeError: Cannot read properties of null (reading 'context')

TypeError: Cannot read properties of null (reading 'surface')

TypeError: Cannot read property 'surface' of null

TypeError: Cannot read property 'context' of null

TypeError: Cannot read properties of undefined (reading '$element')

TypeError: window.ve.init._target.surface is null

So far, I did not notice any users' impact.

Etonkovidova moved this task from Inbox to Needs Discussion on the Growth-Team board.Oct 27 2023, 7:06 PM

Etonkovidova mentioned this in T349939: mw-client-growth-team-errors dashboard errors.Oct 27 2023, 7:50 PM

Umherirrender added a project: JavaScript.Oct 28 2023, 12:32 AM

Sgs edited projects, added Growth-Team (Sprint 2 (Growth Team)), GrowthExperiments-Help panel; removed GrowthExperiments, Growth-Team.Oct 31 2023, 11:40 AM

KStoller-WMF set the point value for this task to 4.Oct 31 2023, 4:22 PM

Sgs moved this task from Incoming to Ready on the Growth-Team (Sprint 2 (Growth Team)) board.Oct 31 2023, 5:13 PM

FTR, this can be reliably reproduced when Add Image Suggested edits is being submitted.

Urbanecm_WMF triaged this task as High priority.Nov 5 2023, 1:24 AM

KStoller-WMF edited projects, added Growth-Team (Sprint 3 (Growth Team)); removed Growth-Team (Sprint 2 (Growth Team)).Nov 14 2023, 2:43 PM

KStoller-WMF edited projects, added Growth-Team (Sprint 4 (Growth Team)); removed Growth-Team (Sprint 3 (Growth Team)).Nov 28 2023, 2:35 PM

Sgs claimed this task.Nov 28 2023, 6:56 PM

Sgs moved this task from Incoming to Doing on the Growth-Team (Sprint 4 (Growth Team)) board.

Checked the logstash link from https://phabricator.wikimedia.org/T349933#9288365 - there are 410 errors in 24 hours.

I wasn't able to trigger the error in beta (testwiki doesn't have image suggestions). I tried minerva skin with slow connection - adding, rejecting, and skipping images seem to be fine.

KStoller-WMF edited projects, added Growth-Team (Sprint 5 (Growth Team)); removed Growth-Team (Sprint 4 (Growth Team)).Dec 12 2023, 2:52 PM

Sgs moved this task from Incoming to Doing on the Growth-Team (Sprint 5 (Growth Team)) board.Dec 12 2023, 4:49 PM

In T349933#9302252, @Urbanecm_WMF wrote:

FTR, this can be reliably reproduced when Add Image Suggested edits is being submitted.

I haven't been able to reproduce it reliably with Add Image submissions or any other mechanism. I was able to reproduce it somehow reliably in production wikis. There was a clear drop on the rate after the the 15th December deployment, probably because of 978117. However it seems the editor surface is still null on mobile in some cases, no idea why :/

Sgs moved this task from Doing to Blocked / Needs Work on the Growth-Team (Sprint 5 (Growth Team)) board.Jan 8 2024, 5:13 PM

Trizek-WMF subscribed.Jan 8 2024, 5:19 PM

KStoller-WMF edited projects, added Growth-Team (Sprint 6 (Growth Team)); removed Growth-Team (Sprint 5 (Growth Team)), GrowthExperiments-Help panel, JavaScript, Wikimedia-production-error.Jan 9 2024, 5:39 PM

Sgs moved this task from Incoming to Blocked / Needs Work on the Growth-Team (Sprint 6 (Growth Team)) board.Jan 9 2024, 5:40 PM

Urbanecm_WMF added projects: GrowthExperiments-Help panel, JavaScript, Wikimedia-production-error.Jan 10 2024, 3:04 PM

KStoller-WMF moved this task from Blocked / Needs Work to Doing on the Growth-Team (Sprint 6 (Growth Team)) board.Jan 17 2024, 5:09 PM

KStoller-WMF edited projects, added Growth-Team (Sprint 7 (Growth Team)); removed Growth-Team (Sprint 6 (Growth Team)).Feb 6 2024, 12:47 AM

Sgs moved this task from Incoming to Doing on the Growth-Team (Sprint 7 (Growth Team)) board.Feb 6 2024, 12:08 PM

• brennen moved this task from Untriaged to October 2023 on the Wikimedia-production-error board.Feb 8 2024, 4:23 PM

KStoller-WMF edited projects, added Growth-Team (Sprint 8 (Growth Team)); removed Growth-Team (Sprint 7 (Growth Team)).Feb 19 2024, 11:53 PM

Sgs moved this task from Incoming to Doing on the Growth-Team (Sprint 8 (Growth Team)) board.Feb 20 2024, 12:21 PM

KStoller-WMF edited projects, added Growth-Team (Sprint 9 (Growth Team)); removed Growth-Team (Sprint 8 (Growth Team)).Mar 5 2024, 4:20 PM