Transcluded special page includes superfluous text
Open, Needs TriagePublic
Actions

Assigned To

Authored By

	RhinosF1
	Feb 7 2024, 7:54 AM

Description

Reported in Miraheze discord. Since https://github.com/wikimedia/mediawiki-extensions-Editcount/commit/e5657bc2997f6bfbc1f35f3f019847d6639ad03c, the Editcount-before message is included in both the special page and the transcluded page.

This breaks using the special page in a template.

The editcount-before message should be moved to inside the else of this->including

Details

	Subject	Repo	Branch	Lines +/-
	Only show leading message if it's not being transcluded	mediawiki/extensions/Editcount	master	+3 -2

Customize query in gerrit

Event Timeline

RhinosF1 created this task.Feb 7 2024, 7:54 AM

Restricted Application added subscribers: Reception123, Aklapper. · View Herald TranscriptFeb 7 2024, 7:54 AM

TehKittyCat subscribed.Apr 14 2024, 8:12 PM

BlankEclair renamed this task from Transcluded special page includes suprious text to Transcluded special page includes superfluous text.Fri, Dec 13, 5:17 AM

BlankEclair claimed this task.

Change #1103138 had a related patch set uploaded (by BlankEclair; author: BlankEclair):

[mediawiki/extensions/Editcount@master] Only show leading message if it's not being transcluded

https://gerrit.wikimedia.org/r/1103138

gerritbot added a project: Patch-For-Review.Fri, Dec 13, 5:24 AM

Change #1103138 merged by jenkins-bot: