Page MenuHomePhabricator

Enable new heading markup on Vector 2022
Closed, ResolvedPublic

Description

NOTE: Planned deploy is train that runs week of July 14th

Background

After T365736, Vector 2022 is the only remaining skin to update. As expected there were a few gadget breakages which should be fixed now. Once we are confident these have been addressed, we can finish the roll out.

User story

As a reader I want to benefit from more accessible heading markup.

Requirements

  • Vector 2022 should get the new heading markup.
  • Logstash is monitored preceding the deploy
  • we address any problems with gadgets relating to this change.

QA steps

  1. Desktop (Vector 2022)
  2. Check the table of contents works and that headings correspond to the titles
  3. Check there are no visual problems with the heading e.g. misaligned icons/unexpected icons in strange places

Rollback plan

For severe breakages revert the patch https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/1035482
Hopefully this has been mitigated by the staged rollout and won't be a problem.

Sign off steps

  • Review any open tasks and follow up work with Bartosz
  • Make sure there is a removal/deprecation ticket for supportsHeading in some future MediaWiki release.

This task was created by Version 1.0.0 of the Web team task template using phabulous

QA Results - PROD

ACStatusDetails
1T367601#9997089

Event Timeline

Change #1035482 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] [Vector 2022] Indicate support for new heading HTML

https://gerrit.wikimedia.org/r/1035482

Jdlrobson moved this task from Incoming to Groomed on the Web-Team-Backlog board.

Change #1035482 merged by jenkins-bot:

[mediawiki/skins/Vector@master] [Vector 2022] Indicate support for new heading HTML

https://gerrit.wikimedia.org/r/1035482

Test Result - PROD

Status: ✅ PASS
Environment: PROD
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps
WAD TOC
2024-07-18_13-08-39.mp4.gif (922×1 px, 1 MB)
Not Expanding for the Sub-Category
As mentioned in Team Sync, this may be OK for now
2024-07-18_13-10-57.mp4.gif (916×1 px, 3 MB)

All quiet on the wikis so far but I'll leave this open another day in case people who missed the many communications wake up tomorrow to gadgets not working.

  NODES
HOME 1
mac 1
macOS 1
Note 4
os 6
Verify 2
visual 1
web 10