Namespace select is blank
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Description

What is the problem?

The Namespace select component on Special:AllPages (and presumably other pages) is blank.

The HTML is just:

<select name="namespace" id="ooui-php-3" class="oo-ui-inputWidget-input oo-ui-indicator-down"></select>

It did not happen before https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1084130.

Steps to reproduce problem

Go to Special:AllPages
Click the Namespace select

Environment

Browser: Firefox 128
Wiki(s): https://en.wikipedia.beta.wmflabs.org MediaWiki 1.44.0-alpha (f0dfd5e) 07:04, 1 November 2024.

Details

	Subject	Repo	Branch	Lines +/-
	NamespaceInputWidget: Correctly set default for 'include'	mediawiki/core	master	+38 -2

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	jnuche	T375661 1.44.0-wmf.2 deployment blockers
		Resolved	BUG REPORT	Dreamy_Jazz	T378810 Namespace select is blank

Event Timeline

dom_walden created this task.Nov 1 2024, 1:21 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 1 2024, 1:21 PM

dom_walden mentioned this in T378179: Restrict namespace filtering on Special:GlobalContributions to common namespaces.Nov 1 2024, 1:22 PM

kostajh triaged this task as High priority.Nov 1 2024, 3:57 PM

kostajh added a project: Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15).

kostajh added a parent task: T375661: 1.44.0-wmf.2 deployment blockers.

This was working at commit e438c515bf9390dcb8cb2049298deb0f087439bb and is broken on the master branch. It's not broken when I disable JavaScript.

Appears to be caused by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1084130/11/resources/src/mediawiki.widgets/mw.widgets.NamespaceInputWidget.js

JJMC89 raised the priority of this task from High to Unbreak Now!.Nov 1 2024, 4:06 PM

Found the cause: https://gerrit.wikimedia.org/g/mediawiki/core/+/refs/changes/30/1084130/11/includes/widget/NamespaceInputWidget.php#42

The default was set as the include option being an empty array, which excludes everything. It should instead be null.

Change #1085616 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] NamespaceInputWidget: Correctly set default for 'include'

https://gerrit.wikimedia.org/r/1085616

gerritbot added a project: Patch-For-Review.Nov 1 2024, 4:29 PM

Fix has been +2'd. Should be ready for QA shortly on the beta cluster / locally.

Change #1085616 merged by jenkins-bot:

[mediawiki/core@master] NamespaceInputWidget: Correctly set default for 'include'

https://gerrit.wikimedia.org/r/1085616

Maintenance_bot removed a project: Patch-For-Review.Nov 1 2024, 5:30 PM

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.2; 2024-11-05).Nov 1 2024, 6:00 PM

I see the namespace select populated with what appear to be the correct namespaces in a few different special pages, including Special:Contributions, Special:Export (with $wgExportFromNamespaces) and Special:MovePage. When submitting the form with a namespace selected it appeared to return results from that namespace.

I tested with and without JavaScript.

I also briefly retested Special:GlobalContributions.

Test environments:

https://en.wikipedia.beta.wmflabs.org MediaWiki 1.44.0-alpha (168d596) 07:05, 4 November 2024.
local docker MediaWiki 1.44.0-alpha (168d596) 07:05, 4 November 2024.

Dreamy_Jazz closed this task as Resolved.Nov 4 2024, 8:30 AM

Namespace select is blankClosed, ResolvedPublic1 Estimated Story PointsBUG REPORTActions