Page MenuHomePhabricator
Create Task
Maniphest T380720

[ES-M3] Create and populate descriptions field for EntitySchema
Open, Needs TriagePublic
Actions

Assigned To
None
Authored By
Lucas_Werkmeister_WMDE
Nov 25 2024, 10:59 AM
Tags
Referenced Files
None
Subscribers
Aklapper
Arian_Bozorg
AudreyPenven_WMDE
• dcausse
hoo
karapayneWMDE
Lucas_Werkmeister_WMDE
Lydia_Pintscher

Description

Like T376250 and T376251, but for descriptions rather than labels and aliases. Descriptions aren’t searched for, but should be displayed with search results (T376252), so we also want them in the index.

Details

SubjectRepoBranchLines +/-
Create and populate descriptions fieldmediawiki/extensions/EntitySchemamaster+120 -32
Introduce WikibaseDescriptionsIndexFieldmediawiki/extensions/WikibaseCirrusSearchmaster+70 -32
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lucas_Werkmeister_WMDE created this task.Nov 25 2024, 10:59 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 25 2024, 10:59 AM
Lucas_Werkmeister_WMDE moved this task from In Task Breakdown to Ready for Development on the Wikidata Dev Team (Wikidata.org Slice) board.Nov 26 2024, 9:18 AM
gerritbot added a comment.Nov 26 2024, 2:58 PM

Change #1098054 had a related patch set uploaded (by Audrey Penven; author: Audrey Penven):

[mediawiki/extensions/WikibaseCirrusSearch@master] Introduce WikibaseDescriptionsIndexField

https://gerrit.wikimedia.org/r/1098054

gerritbot added a project: Patch-For-Review.Nov 26 2024, 2:58 PM
gerritbot added a comment.Nov 26 2024, 3:02 PM

Change #1098055 had a related patch set uploaded (by Audrey Penven; author: Audrey Penven):

[mediawiki/extensions/EntitySchema@master] Create and populate descriptions field

https://gerrit.wikimedia.org/r/1098055

Lucas_Werkmeister_WMDE assigned this task to AudreyPenven_WMDE.EditedNov 26 2024, 3:30 PM
Lucas_Werkmeister_WMDE moved this task from Ready for Development to In Development on the Wikidata Dev Team (Wikidata.org Slice) board.

Audrey and I paired on this today and will continue with it later. (The WikibaseCirrusSearch part should be mostly ready, EntitySchema still needs some tests updated.)

Lucas_Werkmeister_WMDE removed AudreyPenven_WMDE as the assignee of this task.Nov 27 2024, 3:09 PM
Lucas_Werkmeister_WMDE moved this task from In Development to Ready for Peer Review on the Wikidata Dev Team (Wikidata.org Slice) board.
Lucas_Werkmeister_WMDE added a subscriber: AudreyPenven_WMDE.
Lucas_Werkmeister_WMDE mentioned this in T376252: [ES-M3]: Create a EntitySearchHelper implementation that uses elastic.Nov 27 2024, 3:40 PM
ArthurTaylor moved this task from Ready for Peer Review to Ready for Tech Verification on the Wikidata Dev Team (Wikidata.org Slice) board.Nov 28 2024, 8:30 AM
gerritbot added a comment.Nov 28 2024, 8:45 AM

Change #1098054 merged by jenkins-bot:

[mediawiki/extensions/WikibaseCirrusSearch@master] Introduce WikibaseDescriptionsIndexField

https://gerrit.wikimedia.org/r/1098054

gerritbot added a comment.Nov 28 2024, 8:50 AM

Change #1098055 merged by jenkins-bot:

[mediawiki/extensions/EntitySchema@master] Create and populate descriptions field

https://gerrit.wikimedia.org/r/1098055

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.6; 2024-12-03).Nov 28 2024, 9:00 AM
Maintenance_bot removed a project: Patch-For-Review.Nov 28 2024, 9:30 AM
Lucas_Werkmeister_WMDE moved this task from Ready for Tech Verification to In Tech Verification on the Wikidata Dev Team (Wikidata.org Slice) board.Nov 28 2024, 11:56 AM

Let’s park this in tech verification for now – I reckon the actual verification will be that search, as a whole, works (i.e. once T376252 is also done).

Lucas_Werkmeister_WMDE moved this task from In Tech Verification to Ready for Tech Verification on the Wikidata Dev Team (Wikidata.org Slice) board.Nov 28 2024, 11:57 AM

(It already was in Ready for Tech Verification, which is the column I had in mind 🤦)

karapayneWMDE edited projects, added EntitySchema (M3: EntitySchemas shown as labels instead of ID); removed EntitySchema (M2: Linking to EntitySchemas in statements).Nov 29 2024, 2:36 PM
karapayneWMDE renamed this task from Create and populate descriptions field for EntitySchema to [ES-M3] Create and populate descriptions field for EntitySchema.Nov 29 2024, 2:38 PM
karapayneWMDE moved this task from Ready for Tech Verification to Done on the Wikidata Dev Team (Wikidata.org Slice) board.Dec 2 2024, 8:33 AM
karapayneWMDE subscribed.

I'll move this to the done column but leave it unresolved until we do the final verification of search

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits
  NODES
HOME 1
Note 3
os 3