Page MenuHomePhabricator

Support appending to the toolbox in a similar fashion as [[MediaWiki:Sidebar]]
Closed, ResolvedPublicFeature

Description

Background

Currently it's possible to append to the toolbox by using mw.util.addPortletLink or via the SkinTemplateNavigation hook, however it's not possible to extend it via the MediaWiki:Sidebar. In Vector 2022 this change would be significant given the toolbox can appear on the right hand side of the screen and is more prominent.

User story

As a site admin, I want to easily be able to add links to the toolbox without introducing a delay by loading it via JavaScript

Acceptance criteria

  • When editing MediaWiki:sidebar with the following text:
* navigation
** mainpage|mainpage-description
** currentevents-url|currentevents
** Wikipedia:Contents|contents
** randompage-url|randompage
** Wikipedia:About|aboutsite
** contact-url|contactpage
** sitesupport-url|sitesupport
* SEARCH
* interaction
** helppage|help
** portal-url|portal
** recentchanges-url|recentchanges
** Wikipedia:File Upload Wizard|upload
* TOOLBOX
** toolbox-link|toolbox-label

a link should be added at the end of the toolbox.

Original bug

Author: gangleri

Description:
This is a counterpart for
Bug 419: Make it easier to add links to the sidebar (navbar)

Hallo!

According to Brion there is no way to add new items to the "toolbox" using
MediaWiki messages.

Some wiki's may require adaptations to the toolbox as additional links for
transliterations etc.

Please implement this in a similar fassion as [[MediaWiki:Sidebar]].

Thanks in advance! best regards reinhardt [[user:gangleri]]


Version: unspecified
Severity: enhancement

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 8:58 PM
bzimport set Reference to bz4086.
bzimport added a subscriber: Unknown Object (MLST).

avarab wrote:

(In reply to comment #0)

Please implement this in a similar fassion as [[MediaWiki:Sidebar]].

The reason I didn't do this when I implemented MediaWiki:Sidebar is that the
toolbox requires complex logic while the Sidebar doesn't, Some links are only
displayed on certain classes of pages, some are displayed differently when oldid
equals a certain thing etc. etc. It's not simple to represend that in a syntax
like the sidebar.

gangleri wrote:

(In reply to comment #1)

(In reply to comment #0)

Please implement this in a similar fassion as [[MediaWiki:Sidebar]].

The reason I didn't do this when I implemented MediaWiki:Sidebar is that the
toolbox requires complex logic while the Sidebar doesn't, Some links are only
displayed on certain classes of pages, some are displayed differently when oldid
equals a certain thing etc. etc. It's not simple to represend that in a syntax
like the sidebar.

Thanks Ævar for the comment!

Could we have a Toolbox *trailer* as [[MediaWiki:Toolboxtrailer]] which would be
appended to whatever the "complex logic" requires / generates? I know there a
lot of dependencies there depending on namespace, existence of pages etc.

best regards reinhardt [[user:gangleri]]

robchur wrote:

What would you append there that you couldn't put in the regular navigation bar,
might I ask?

gangleri wrote:

(In reply to comment #4)

What would you append there that you couldn't put in the regular navigation bar,
might I ask?

See [[wiktionary:yi:MediaWiki:Sidebar]] which contains links to utilities / tools:
a) The first one "shraybmashinke

  • שרײַבמאַשינקע" is quite powerfull because it includes a spelling checker,

different transliteration features, various character conversion tools and also
a .gif / .pdf generator.
b) The second one is also a typewriter.
c) A link to a list of additional utilities could be added as to many of the
links mentioned at the moment at [[wiktionary:yi:project:Guide_to_vikiverterbukh]]

These are *tools* and should not belong to *navigation*. As it is done now
[[MediaWiki:Toolbox]] apears twice.

best regards reinhardt [[user:gangleri]]

robchur wrote:

*** Bug 7394 has been marked as a duplicate of this bug. ***

herd wrote:

With enhanced sidebar over-positioning possible the syntax could simply be (to append):

  • TOOLBOX
    • my link|link text

One problem with this would be... you'd *have* to define "* TOOLBOX", which, if you want it to appear below something like the new collection extension portlet, can't be defined.

Jdlrobson subscribed.

Pretty straightforward to do. We just need to do an array merge when we read mediawiki sidebar, rather than clobber it.

https://github.com/wikimedia/mediawiki/blob/master/includes/skins/Skin.php#L1541

Aklapper changed the subtype of this task from "Task" to "Feature Request".Feb 4 2022, 11:02 AM
Aklapper removed a subscriber: wikibugs-l-list.
Lens0021 renamed this task from Support appending to the toolbox to Support appending to the toolbox in a similar fassion as [[MediaWiki:Sidebar]].Apr 13 2022, 4:50 PM

@Jdlrobson Initially, this was moved to the MW platform team but seems to be unowned, could please you clarify how the MW can be useful for this task?

@MSantos the owners of the code that would need to be changed here are unclear/ambiguous. My assumption is either the web team or mediawiki platform maintain this part of the codebase. I think we can worry about that if and once a patch exists or there's a pressing need to fix this. Does that make sense?

@MSantos the owners of the code that would need to be changed here are unclear/ambiguous. My assumption is either the web team or mediawiki platform maintain this part of the codebase. I think we can worry about that if and once a patch exists or there's a pressing need to fix this. Does that make sense?

Looks good to me. I'll move it on our board to reflect reality. Thank you so much!

Pppery renamed this task from Support appending to the toolbox in a similar fassion as [[MediaWiki:Sidebar]] to Support appending to the toolbox in a similar fashion as [[MediaWiki:Sidebar]].Feb 9 2024, 3:15 AM

Change #1034924 had a related patch set uploaded (by Sohom Datta; author: Sohom Datta):

[mediawiki/core@master] Allow Toolbox links to be configured from MediaWiki:Sidebar

https://gerrit.wikimedia.org/r/1034924

Thanks for the patch @sohom ! I've had a first pass of review and I'm reaching out to the MediaWiki platform team to see if they want to be involved in code review for this ticket. Thanks for your patience!

Krinkle assigned this task to Soda.
Krinkle subscribed.

Marking resolved as patch is merged and task is not on any other team workboards.

Change #1034924 merged by jenkins-bot:

[mediawiki/core@master] skins: Allow Toolbox links to be configured from MediaWiki:Sidebar

https://gerrit.wikimedia.org/r/1034924

Quiddity subscribed.

[re-opening until documentation is updated]
For Tech News, how should this be described? [1-4 simple sentences, 1-2 links].
And, is there any documentation to link to?

From a quick-search, it appears that something ought to be added (and perhaps other parts updated) within
https://www.mediawiki.org/wiki/Manual:Interface/Sidebar
Please could someone take a look at that?

My best-guess for a Tech News entry is the following. Please suggest any improvements:

  • It is now possible for local administrators to add new links to the bottom of the Tools menu without JavaScript. Documentation is available[???].

I made a few edits to https://www.mediawiki.org/wiki/Manual:Interface/Sidebar#Add_or_remove_toolbox_sections but that page seems very outdated - but perhaps sharing it on tech news will get it some more updates!

Thank you! I'll re-close this, and I've added an entry to https://meta.wikimedia.org/wiki/Tech/News/2024/23 - If changes to the wording are needed, please edit directly or comment here within ~22 hours, after which it will be frozen for translations. Thanks!

  NODES
admin 2
Bugs 1
Note 3
Project 17