Page MenuHomePhabricator
Create Task
Maniphest T91442

The transition while switching between Readmode and VE is now not smooth, new content is inserted before the old content is removed leading to a flicker
Closed, ResolvedPublic8 Estimated Story Points
Actions

Assigned To
Krinkle
Authored By
Ryasmeen
Mar 3 2015, 9:14 PM
Tags
Referenced Files
F54229: flickering_content.mov
Mar 3 2015, 9:14 PM
Subscribers
Aklapper
• Catrope
Etonkovidova
gerritbot
Ryasmeen

Description

Steps to reproduce:

1.Open a page with Ve
2.Type something and Save the content
3.Now again click on Edit
4.Switch back and forth between Read mode and VE

Observed Result:
The whole block of content repeats as a flicker below the actual content

flickering_content.mov5 MBDownload

Details

SubjectRepoBranchLines +/-
mw.ViewPage_target: Hide ve-ui-surface during activation as wellmediawiki/extensions/VisualEditorwmf/1.25wmf21+1 -0
mw.ViewPage_target: Hide ve-ui-surface during activation as wellmediawiki/extensions/VisualEditormaster+1 -0
mw.ViewPage_target: Hide ve-ui-surface instead of ve-ce-surfacemediawiki/extensions/VisualEditorwmf/1.25wmf21+1 -1
mw.ViewPage_target: Hide ve-ui-surface instead of ve-ce-surfacemediawiki/extensions/VisualEditormaster+1 -1
mw.ViewPage_target: Hide ve-ce-surface during deactivationmediawiki/extensions/VisualEditormaster+2 -1
Customize query in gerrit

Related Objects

Event Timeline

Ryasmeen created this task.Mar 3 2015, 9:14 PM
Ryasmeen raised the priority of this task from to Needs Triage.
Ryasmeen updated the task description. (Show Details)
Ryasmeen added a project: VisualEditor.
Ryasmeen subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 3 2015, 9:14 PM
Aklapper added a comment.Mar 4 2015, 10:09 AM

With which browsers was this tested?

Ryasmeen moved this task from To Triage to External and Administrivia on the VisualEditor board.Mar 6 2015, 8:42 PM
Etonkovidova subscribed.Mar 6 2015, 10:48 PM

I saw the issue on FF35, Chrome40, and Safari7. And I noticed another one which seems to me the same issue.

FF 35 betalabs, test2 and production. Chrome is ok.

  1. In FF35, open a page with content that fills more than a screen length, e.g. https://en.wikipedia.org/wiki/Geometry
  2. Click on Edit - the page will be scrolled down.
  1. Even if you edit at the very beginning of an article - Save, and then switch between modes. It will make a page scroll to the bottom.

When there is not enough text to fill the whole screen - then that "flickering" effect will be observed.

Ryasmeen added a comment.Mar 6 2015, 10:52 PM

@Aklapper: This is not a browser specific issue , happens in both Chrome and Firefox.
@Etonkovidova: Thats a separate issue and already reported at https://phabricator.wikimedia.org/T90420

Jdforrester-WMF renamed this task from [Regression pre-wmf20] The transition while switching between Readmode and VE is not smooth, the whole block of content repeats as a flicker below the actual content to The transition while switching between Readmode and VE is now not smooth, new content is inserted before the old content is removed leading to a flicker.Mar 9 2015, 3:29 PM
Jdforrester-WMF assigned this task to Krinkle.
Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF added a project: VisualEditor-MediaWiki.
Jdforrester-WMF set Security to None.
gerritbot subscribed.Mar 10 2015, 1:44 AM

Change 195496 had a related patch set uploaded (by Krinkle):
mw.ViewPage_target: Keep pageview content hidden until surface teardown is ready

https://gerrit.wikimedia.org/r/195496

gerritbot added a project: Patch-For-Review.Mar 10 2015, 1:44 AM
gerritbot added a comment.Mar 10 2015, 9:58 AM

Change 195496 merged by jenkins-bot:
mw.ViewPage_target: Hide ve-ce-surface during deactivation

https://gerrit.wikimedia.org/r/195496

Krinkle mentioned this in rEVED77f016ae8fb1: mw.ViewPage_target: Hide ve-ce-surface during deactivation.Mar 10 2015, 9:59 AM
Jdforrester-WMF closed this task as Resolved.Mar 10 2015, 3:26 PM
Jdforrester-WMF edited projects, added WMF-deploy-2015-03-11_(1.25wmf21); removed Patch-For-Review.
Jdforrester-WMF moved this task from External and Administrivia to FY 18-19 Q3/Q4 on the VisualEditor board.Mar 10 2015, 4:15 PM
Ryasmeen reopened this task as Open.Mar 11 2015, 5:29 PM

Still happening when I open VE from read mode

Krinkle added a comment.Mar 12 2015, 12:17 AM

Yep. Confirmed. The commit fixed the behaviour during deactivation. But during activation (at the very end, right before the surface is enabled) they briefly appear together. Causing the same scroll and offset issues as previously mentioned for the deactivation.

• Catrope subscribed.Mar 12 2015, 9:25 AM
In T91442#1111715, @Krinkle wrote:

Yep. Confirmed. The commit fixed the behaviour during deactivation. But during activation (at the very end, right before the surface is enabled) they briefly appear together. Causing the same scroll and offset issues as previously mentioned for the deactivation.

That was also the immediate cause of T90420 , although Moriel fixed that in a different way(by calling focus later).

gerritbot added a comment.Mar 12 2015, 4:03 PM

Change 196250 had a related patch set uploaded (by Krinkle):
mw.ViewPage_target: Hide ve-ui-surface instead of ve-ce-surface

https://gerrit.wikimedia.org/r/196250

gerritbot added a project: Patch-For-Review.Mar 12 2015, 4:04 PM

Change 196251 had a related patch set uploaded (by Krinkle):
mw.ViewPage_target: Hide ve-ui-surface during activation as well.

https://gerrit.wikimedia.org/r/196251

gerritbot added a comment.Mar 12 2015, 5:25 PM

Change 196250 merged by jenkins-bot:
mw.ViewPage_target: Hide ve-ui-surface instead of ve-ce-surface

https://gerrit.wikimedia.org/r/196250

gerritbot added a comment.Mar 12 2015, 5:25 PM

Change 196269 had a related patch set uploaded (by Jforrester):
mw.ViewPage_target: Hide ve-ui-surface instead of ve-ce-surface

https://gerrit.wikimedia.org/r/196269

Krinkle mentioned this in rEVEDcaa58d31c5bc: mw.ViewPage_target: Hide ve-ui-surface instead of ve-ce-surface.Mar 12 2015, 5:25 PM
gerritbot added a comment.Mar 12 2015, 5:26 PM

Change 196251 merged by jenkins-bot:
mw.ViewPage_target: Hide ve-ui-surface during activation as well

https://gerrit.wikimedia.org/r/196251

Krinkle mentioned this in rEVED93f5697586bc: mw.ViewPage_target: Hide ve-ui-surface during activation as well.Mar 12 2015, 5:27 PM
gerritbot added a comment.Mar 12 2015, 5:57 PM

Change 196269 merged by jenkins-bot:
mw.ViewPage_target: Hide ve-ui-surface instead of ve-ce-surface

https://gerrit.wikimedia.org/r/196269

Jdforrester-WMF mentioned this in rEVEDc158a2c556e9: mw.ViewPage_target: Hide ve-ui-surface instead of ve-ce-surface.Mar 12 2015, 5:57 PM
gerritbot added a comment.Mar 12 2015, 5:59 PM

Change 196280 had a related patch set uploaded (by Jforrester):
mw.ViewPage_target: Hide ve-ui-surface during activation as well

https://gerrit.wikimedia.org/r/196280

gerritbot added a comment.Mar 12 2015, 9:23 PM

Change 196280 merged by jenkins-bot:
mw.ViewPage_target: Hide ve-ui-surface during activation as well

https://gerrit.wikimedia.org/r/196280

Jdforrester-WMF mentioned this in rEVED4acc973fe865: mw.ViewPage_target: Hide ve-ui-surface during activation as well.Mar 12 2015, 9:24 PM
Jdforrester-WMF closed this task as Resolved.Mar 16 2015, 6:37 PM
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF added a project: VisualEditor 2014/15 Q3 blockers.Mar 29 2015, 11:27 PM
Jdforrester-WMF edited a custom field.Mar 29 2015, 11:30 PM
Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q3 blockers board.Mar 29 2015, 11:49 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits
  NODES
HOME 1
Note 1
os 4
text 1
visual 15