@Volker_E in the design sync, we agreed that @bmartinezcalvo would open a task to document future improvements to the VitePress search UI

Thanks all - I've updated this demo to have:

I also generally concur with @lwatson - thus far, I think it makes the most sense to have everything in a group. However, if we're able to get the visual hierarchy right for the mixture of grouped and ungrouped items, I might feel differently.

paging @Catrope, who in gerrit mentioned not liking having groups collapsed initially

@bmartinezcalvo @DTorsani-WMF @egardner @lwatson @Volker_E Here's the proof-of-concept that groups some items but not all. Please let me know what you think here in the task (not on the patch)!

Without visual indication the list of 'dos' and 'donts' is not clear to AT. Wasn't before, but should be improved IMO.

lol that's very on-brand...thanks for confirming that this change is in line with our browser support matrix. I'll move forward with reviewing the patch.

@Catrope got it, thanks for the context! If we can verify that we're not shipping to browsers that don't support ES2016 then I'm happy to move forward with this.

I'm all for this! Can we attempt to quantify how many end users may still be using browsers that don't support ES2016, or have there been other efforts to determine whether we risk creating issues for anyone? I don't know what the consequences might be for users if we make this upgrade.

In T309109#10410263, @bmartinezcalvo wrote:

• I wonder if we could name the "Actions" section just "Buttons" and move the MenuButton there. I feel a bit confusing having just this MenuButton separated from the rest of buttons.

Copying @Volker_E's feedback from gerrit:

I'm playing around with the new local search feature

Noting here that readonly styles and inut behavior currently exist in Lookup because the readonly attribute gets passed to the internal TextInput. However, if there are menu items (such as the case of initial suggestions), the menu will open and be accessible even in the readonly state.

Thanks @DTorsani-WMF - I've just pushed an update to the base patch with the updated accordion styles!

@DTorsani-WMF one thing of note is that we should never have the controls (the configurable part of the demo) and developer notes in the same demo, because we are moving all configurable demos to the top of the page and they should never have developer notes.

@Jdlrobson I think it's fine to close at this point.

Re 2, I've updated the styles and this is what the best practices list looks like now:

Yes, thanks so much for your thoughtful comments, @bmartinezcalvo! I especially think your ideas for improving the demos will make the pages a lot better.

To fix this, I believe we need to add media queries for high contrast mode to resources/skins.vector.styles/CSSCustomProperties.less, which sets up dark mode tokens in Vector.

@CCiufo-WMF I've confirmed this now works as expected

One note about how Toasts should interact with other fixed or floating elements: If we want to ensure that Toasts are shown in the right order/placement when there are things like floating buttons, bottom sheets, or even Toasts from other features, we would need to implement a system in MediaWiki to send Toasts to the right place on the page with the right z-index, position, etc. This would not be part of the Toast component itself.

Great work @OTichonova!

We'll use the engineering enclave next week to discuss as a group if we have time, otherwise we'll create a separate meeting.

Yeah, okay, I'm also have trouble getting the right border styles to work due to the unusual structure of the table, so I think I'll abandon this. I am concerned about the hyphens issue affecting real users, so we should consider tackling that early next year.

@egardner huh, I stand corrected - consecutive tbody tags are allowed!

I've played around with migrating 2 TablePagers, the one on Special:AllMessages and the one on Special:ProtectedPages. There are issues with both.

Resolving since this won't actually be part of the next release as a WIP component. Thanks @Dogu!