You can just as easily get feedback there as here.

it is best to close that task and discuss the issue again here?

Well, right now it fires no hook at all, so scripts have little hope of dealing with it in a reliable manner.

Are you seeing it trigger for the visual diff, or only for the preview under the diff? Because I only see it trigger for the latter.

I can't say that having to change various references to login.toolforge.org in my stuff to login-buster.toolforge.org (which seems like it will only work temporarily) seems like a very good solution.

In T360488#9677736, @bd808 wrote:

Dropping this into the "needs discussion" column for cloud-services-team as a blocker to decommissioning the remaining Buster bastions.

For context, assert=user is basically a fallback check to ensure that your login session hasn't expired, and that you didn't mess up the cookie handling in your code,

Possibly I could set up my ~/.ssh/config with an entry that would use ProxyCommand to ssh→become→webservice shell→sshd -i though...

webservice perl5.32 shell

Provide something better that fits the requirements and I'll look at using it. Last I've heard there's nothing else at all available.

Thanks!

In T352060#9363489, @Jdforrester-WMF wrote:

CI is still not going to be voting on 8.3 (or 8.2) due to T325321, but thank you!

I updated https://oauth-hello-world.toolforge.org/index.php to use /wiki/Special:OAuth for you. Looks like the problem is fixed.

Looks like it was probably 5ad8ee4d9268107887883eacf6d1e8481cfe54ee

FYI, that patch was created in January 2020, after the CSS Speech Module was retired in 2018 but before the CSS Speech Module Level 1 was created in March 2020. It wasn't merged until February 2022 because no one else cared (and I was gone from WMF) until someone wanted something in one of the other specs being added or updated there and someone noticed the old patch still lying around.

AnomieBOT is working now. Logs seem to indicate it was fixed sometime after 2023-03-11 04:38:20.

The other two tools I have access to, oauth-hello-world (s51319) and mediawiki-mirror (s52152), both can connect with sql enwiki.

With some help from @bd808 I was able to get the webservice switched over, although I had to disable one feature (status page checking that the pod hadn't gone missing) due to lack of permission to access the Kubernetes API (specifically https://kubernetes.default.svc/api/v1/namespaces/$NAMESPACE/pods/) from inside the container. He said he'd file the Phab task or whatever to have someone look into that.

I think I have the bot's actual jobs all switched over. We'll see if anything blows up.

In T320830#8317655, @JJMC89 wrote:

https://k8s-status.toolforge.org/namespaces/tool-anomiebot/ has quota information and a link to Grafana.

Thanks. It may be a bit before I can check, as I'll also need T320824 to begin.

I did just find a case that updates it incorrectly: viewing an old viewed revision for some reason marks everything as viewed.

All I can say to that is that it still works fine on my local test wiki, diffs in particularly work as I described.

Finally got sick of seeing this and took 20 minutes to look into it (and then found this existing task about it). Looks like the problem was b33524cc93ee3e1a31c045f3c2f934ddaf9c186d, which incorrectly changed the global-ish baseRequestParams into a local variable so it's no longer preserved as intended across calls.

Correct, that's not what the sniff does. But this is what you said.

Perhaps you should search for instances of assertNotTrue or assertNotFalse as well, since your position is that those should never be used.

I'd think it would be unlikely for someone to use assertNotEquals or assertNotSame with a boolean and not intend for the behavior of assertNotTrue/assertNotFalse, otherwise they'd most likely have written it with assertEquals or assertSame and the opposite boolean in the first place.

I don't believe @Anomie has been very active as a volunteer lately, but I'd imagine they would have some relevant guidance to offer on this matter.

I note that the sniffs themselves don't actually require sebastian/diff, its only the Gerrit-specific report formatter that does. To better support reuse of the sniffs by third parties, you might consider moving that report formatter to a different repo so those of us who don't need it don't have to be constrained by its dependencies.

In T274050#6861287, @Cyberpower678 wrote:

Pinging @Anomie

Another option might be to make the trait stuff protected rather than private, so we can subclass the relevant tests and override them.

In T132676#6575067, @Mpaa wrote:

@Anomie is base64 encode supported by api action=upload?

Thanks! I'll resubscribe myself now to the ones I just filed, and any I happen to decide to pay attention to in the future.

All of them, please.