PHP-extension to generate faster diffs for MediaWiki.
- Documentation on mediawiki.org.
- For the page in MediaWiki core which displays differences between two revisions, see MediaWiki-Page-diffs.
PHP-extension to generate faster diffs for MediaWiki.
Looks like there are ⋮ in the visual diffs now at exactly the points where we missed them before.
Is this ticket still relevant? Untagging MobileFrontend as MobileFrontend no longer has any diff code.
The mobile site now uses the same code as the desktop site. Please see T358293 for more information. For any new or related bugs please file them under MediaWiki-Page-diffs
This is not specific to wikidiff2. The problem is somewhere in the PHP build system.
I don't really think it's necessary. Pages can have multiple languages on them. The content language is not necessarily correct. We're detecting whether the page contains Thai characters and running Thai word breaking only if Thai was detected. Profiling indicates that this is not a significant performance problem.
Example reported at T7072
This was done in ecdd1a34bef120d6ddd6ff3e4e37faecc1bfb922, citing T339915.
I split off a formatter hierarchy in 6d62f503fd7063a8d3b57f50e85da5b7780b5a6b. I hope that solves the problem sufficiently.
There was a bug in argument parsing which could have caused this, and it was fixed in c77f72ee4d6f95d25d14f89c2a9f670f2bf438e5. Please reopen this task if the crash is reproducible with wikdiff2 1.14.1.
wikidiff2 configuration settings are now available as $wgWikidiff2Options in MediaWiki.
The project has been deemed complete, with no tuning needed! Closing as declined.
It is not just in the module namespace. The same problem also occurs in the main namespace:
Test wiki on Patch demo by HMonroy (WMF) using patch(es) linked to this task was deleted:
Test wiki on Patch demo by HMonroy (WMF) using patch(es) linked to this task was deleted:
Test wiki on Patch demo by HMonroy (WMF) using patch(es) linked to this task was deleted:
Test wiki on Patch demo by GMikesell-WMF using patch(es) linked to this task was deleted:
In T117279: [EPIC] Core should provide inline diffs as well as side by side (Move InlineDifferenceEngine into core / remove MobileDiff), I posted an example of how bad this can get in MobileDiff:
This would require a change to wikidiff2 to work on our cluster, which at this stage is outside the scope of the Better-Diffs-2023 project.
This was solved by @tstarling and Community-Tech as part of the Better-Diffs-2023 project. That project still isn't officially over (we've got a few lingering bugs here and there to fix), but this task I think can safely be resolved. The example diff looks pretty easy to interpret now :)
Change 959311 merged by jenkins-bot:
[mediawiki/core@REL1_39] ApiComparePages: expose 'difftype' param if wikidiff2 is installed
Change 959311 had a related patch set uploaded (by Reedy; author: MusikAnimal):
[mediawiki/core@REL1_39] ApiComparePages: expose 'difftype' param if wikidiff2 is installed
Change 959275 merged by jenkins-bot:
[mediawiki/core@REL1_40] ApiComparePages: expose 'difftype' param if wikidiff2 is installed
Change 959275 had a related patch set uploaded (by Reedy; author: MusikAnimal):
[mediawiki/core@REL1_40] ApiComparePages: expose 'difftype' param if wikidiff2 is installed
@Umherirrender , it is a design issue, not a backend diff calculation issue.