r31243 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r31242‎ | r31243 | r31244 >
Date:06:42, 25 February 2008
Author:rotem
Status:old
Tags:
Comment:
(bug 13132) Unable to unprotect pages protected with earlier versions of MediaWiki
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Article.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Article.php
@@ -1779,18 +1779,11 @@
17801780 array( 'pr_page' => $id, 'pr_type' => $action
17811781 , 'pr_level' => $restrictions, 'pr_cascade' => $cascade ? 1 : 0
17821782 , 'pr_expiry' => $encodedExpiry ), __METHOD__ );
1783 - if($dbw->affectedRows() != 0)
1784 - $rowsAffected = true;
17851783 } else {
17861784 $dbw->delete( 'page_restrictions', array( 'pr_page' => $id,
17871785 'pr_type' => $action ), __METHOD__ );
1788 - if($dbw->affectedRows() != 0)
1789 - $rowsAffected = true;
17901786 }
17911787 }
1792 - if(!$rowsAffected)
1793 - // No change
1794 - return true;
17951788
17961789 # Insert a null revision
17971790 $nullRevision = Revision::newNullRevision( $dbw, $id, $comment, true );
Index: trunk/phase3/RELEASE-NOTES
@@ -36,6 +36,7 @@
3737 * (bug 10677) Add link to the file description page on the shared repository
3838 * (bug 13084) Increase size of source/destination filename fields in upload form
3939 * (bug 13115) rebuildrecentchanges should print the current value of $wgRCMaxAge
 40+* (bug 13132) Unable to unprotect pages protected with earlier versions of MediaWiki
4041
4142 === API changes in 1.13 ===
4243

Follow-up revisions

RevisionCommit summaryAuthorDate
r31276Revert r31243, r31244 -- regression: spews bogus protection entries into page...brion21:31, 25 February 2008
r31322(bug 13132) Unable to unprotect pages protected with earlier versions of Medi...rotem20:41, 26 February 2008

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r31232Adding fixPageRestrcionts.php, a maintenance script which deals with bug 13132.huji20:11, 24 February 2008

Status & tagging log

  NODES
Note 2