r31394 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r31393‎ | r31394 | r31395 >
Date:01:10, 29 February 2008
Author:brion
Status:old
Tags:
Comment:
* (bug 13031) Add links to usepages in e-mail form
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/SpecialEmailuser.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialEmailuser.php
@@ -92,6 +92,7 @@
9393
9494 function showForm() {
9595 global $wgOut, $wgUser;
 96+ $skin = $wgUser->getSkin();
9697
9798 $wgOut->setPagetitle( wfMsg( "emailpage" ) );
9899 $wgOut->addWikiMsg( "emailpagetext" );
@@ -101,9 +102,11 @@
102103 }
103104
104105 $emf = wfMsg( "emailfrom" );
105 - $sender = $wgUser->getName();
 106+ $senderLink = $skin->makeLinkObj(
 107+ $wgUser->getUserPage(), htmlspecialchars( $wgUser->getName() ) );
106108 $emt = wfMsg( "emailto" );
107 - $rcpt = $this->_target->getName();
 109+ $recipientLink = $skin->makeLinkObj(
 110+ $this->_target->getUserPage(), htmlspecialchars( $this->_target->getName() ) );
108111 $emr = wfMsg( "emailsubject" );
109112 $emm = wfMsg( "emailmessage" );
110113 $ems = wfMsg( "emailsend" );
@@ -119,10 +122,10 @@
120123 <form id=\"emailuser\" method=\"post\" action=\"{$action}\">
121124 <table border='0' id='mailheader'><tr>
122125 <td align='right'>{$emf}:</td>
123 -<td align='left'><strong>" . htmlspecialchars( $sender ) . "</strong></td>
 126+<td align='left'><strong>{$senderLink}</strong></td>
124127 </tr><tr>
125128 <td align='right'>{$emt}:</td>
126 -<td align='left'><strong>" . htmlspecialchars( $rcpt ) . "</strong></td>
 129+<td align='left'><strong>{$recipientLink}</strong></td>
127130 </tr><tr>
128131 <td align='right'>{$emr}:</td>
129132 <td align='left'>
Index: trunk/phase3/RELEASE-NOTES
@@ -59,6 +59,7 @@
6060 to allow functionality on not-quite-right usernames
6161 * (bug 12575) Prevent duplicate patrol log entries from being created
6262 * (bug 13174) __HIDDENCAT__ now applies only to category pages
 63+* (bug 13031) Add links to user pages in e-mail form
6364
6465
6566 === API changes in 1.13 ===

Status & tagging log

  NODES
Note 2
os 2
text 1